Message-ID: <1435461117.3418.32.camel@gmail.com>
Subject: Re: [all better] Re: regression: massive trouble with fpu rework
From: Mike Galbraith <umgwanakikbuti@gmail.com>
To: Henrique de Moraes Holschuh <hmh@hmh.eng.br>
Cc: Ingo Molnar <mingo@kernel.org>, Ingo Molnar <mingo@elte.hu>,
        LKML <linux-kernel@vger.kernel.org>
Date: Sun, 28 Jun 2015 05:11:57 +0200
In-Reply-To: <20150627210238.GB3054@khazad-dum.debian.net>
References: <1435386316.3664.23.camel@gmail.com>
	 <1435393129.3490.7.camel@gmail.com> <20150627082514.GA10894@gmail.com>
	 <1435395328.6545.10.camel@gmail.com>
	 <20150627210238.GB3054@khazad-dum.debian.net>
Content-Type: text/plain; charset="UTF-8"
Mime-Version: 1.0
Content-Transfer-Encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1535
Lines: 39

On Sat, 2015-06-27 at 18:02 -0300, Henrique de Moraes Holschuh wrote:
> On Sat, 27 Jun 2015, Mike Galbraith wrote:
> > > > BIOS setting "Limit CPUID Maximum" upsets new fpu code mightily.
> > 
> > That BIOS setting is annotated with the helpful text "Disabled for
> > Windows XP".  It makes box say interesting things during boot, like...
> > 
> >         x86/fpu: XSTATE_CPUID missing!
> > 
> > 
> > ..or with HEAD, it triggers warning..
> > 
> >         if (boot_cpu_data.cpuid_level < XSTATE_CPUID) {
> >                 WARN_ON_FPU(1);
> >                 return;
> >         }
> > 
> > ..and all kinds of bad juju follows.  I have no idea what the thing does
> > beyond what I can interpolate from the word 'limit'.
> 
> Well, it is supposed to disable CPUID levels >= 0x04.  This thing should
> *NEVER* be enabled, the last operating system that required it to be enabled
> was Windows 98.
> 
> Can/do we override that crap during cpu init?  If we cannot/don't, maybe
> instead of limping along with CPUID crippled, it would be better to either
> output a very nasty warning, or outright stop booting [with an appropriate
> error message] ?

Why get all upset?  We didn't even notice before, nor did/does that
other OS.  A casual "BTW, your BIOS sucks.." should suffice, no?

	-Mike

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/