Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752171AbbF1FYd (ORCPT ); Sun, 28 Jun 2015 01:24:33 -0400 Received: from ozlabs.org ([103.22.144.67]:33259 "EHLO ozlabs.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751000AbbF1FY0 (ORCPT ); Sun, 28 Jun 2015 01:24:26 -0400 From: Rusty Russell To: Stephen Rothwell Cc: Dan Streetman , linux-next@vger.kernel.org, linux-kernel Subject: Re: [PATCH] modules: elide param_lock if !CONFIG_SYSFS In-Reply-To: <20150627102134.00e58047@canb.auug.org.au> References: <1435237448-13684-1-git-send-email-ddstreet@ieee.org> <87616bsd02.fsf@rustcorp.com.au> <20150627102134.00e58047@canb.auug.org.au> User-Agent: Notmuch/0.17 (http://notmuchmail.org) Emacs/24.4.1 (x86_64-pc-linux-gnu) Date: Sun, 28 Jun 2015 14:51:14 +0930 Message-ID: <87vbe8s911.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1323 Lines: 36 Stephen Rothwell writes: > Hi Rusty, > > On Thu, 25 Jun 2015 17:34:31 -0400 Dan Streetman wrote: >> >> On Thu, Jun 25, 2015 at 5:18 PM, Rusty Russell wrote: >> > Dan Streetman writes: >> >> Only include the built-in and per-module param_lock, and corresponding >> >> lock/unlock functions, if sysfs is enabled. If there is no sysfs there >> >> is no need for locking kernel params. >> >> >> >> This fixes a build break when CONFIG_SYSFS is not enabled, introduced >> >> by commit b51d23e. >> > >> > This doesn't even come close to applying to my tree? >> >> sorry, I had the !CONFIG_MODULES patch in my tree also, so this was on >> top of that one: >> https://lkml.org/lkml/2015/6/24/550 >> >> I can resend that one, on top of this one, or you can fix it up. >> >> Sorry for not getting it right the first time ;-) > > This is what I ended up applying to yesterday's linux-next: Thanks, added correct description to previous patch and applied this on top. Sorry for the hassle, Rusty. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/