Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752662AbbF1OB7 (ORCPT ); Sun, 28 Jun 2015 10:01:59 -0400 Received: from muin.pair.com ([209.68.1.55]:62102 "EHLO muin.pair.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752056AbbF1OBw (ORCPT ); Sun, 28 Jun 2015 10:01:52 -0400 Message-ID: <558FFE4E.703@tabi.org> Date: Sun, 28 Jun 2015 09:01:50 -0500 From: Timur Tabi User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.9; rv:36.0) Gecko/20100101 Firefox/36.0 SeaMonkey/2.33.1 MIME-Version: 1.0 To: "Maciej S. Szmigiero" , "alsa-devel@alsa-project.org" CC: Nicolin Chen , Xiubo Li , Liam Girdwood , Mark Brown , Jaroslav Kysela , Takashi Iwai , linuxppc-dev@lists.ozlabs.org, linux-kernel , Fabio Estevam Subject: Re: [PATCH 3/6] ASoC: fsl_ssi: enable AC'97 asymmetric rates References: <558FFAC4.2060608@maciej.szmigiero.name> In-Reply-To: <558FFAC4.2060608@maciej.szmigiero.name> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 621 Lines: 15 Maciej S. Szmigiero wrote: > /* Are the RX and the TX clocks locked? */ > if (!of_find_property(np, "fsl,ssi-asynchronous", NULL)) { > - ssi_private->cpu_dai_drv.symmetric_rates = 1; > + if (!fsl_ssi_is_ac97(ssi_private)) > + ssi_private->cpu_dai_drv.symmetric_rates = 1; > + Is this necessary? Why not just add fsl,ssi-asynchronous to the AC97 device tree node? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/