Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752855AbbF1VqS (ORCPT ); Sun, 28 Jun 2015 17:46:18 -0400 Received: from mail-ig0-f174.google.com ([209.85.213.174]:34314 "EHLO mail-ig0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752625AbbF1VqM (ORCPT ); Sun, 28 Jun 2015 17:46:12 -0400 MIME-Version: 1.0 In-Reply-To: <20150628205925.GX17109@ZenIV.linux.org.uk> References: <20150628205925.GX17109@ZenIV.linux.org.uk> Date: Sun, 28 Jun 2015 14:46:11 -0700 X-Google-Sender-Auth: 6SBpigndPGI-6m_6WxXzvAtsm6Y Message-ID: Subject: Re: [PATCH] hpfs: add fstrim support From: Linus Torvalds To: Al Viro Cc: Mikulas Patocka , "Ted Ts'o" , Linux Kernel Mailing List , linux-fsdevel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 784 Lines: 17 On Sun, Jun 28, 2015 at 1:59 PM, Al Viro wrote: > > More to the point, why bother with ->ioctl() at all? Why not make > ->fitrim() a super_block method and let do_vfs_ioctl() handle all > marshalling? As in > (int *)fitrim(struct super_block *, struct fstrim_range *); > guaranteed to be called only on a filesystem kept active by caller... I'd be ok with that, but that's a bigger issue and I think would be a separate second step from removing the whole compat mess anyway. Linus -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/