Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752310AbbF2HhF (ORCPT ); Mon, 29 Jun 2015 03:37:05 -0400 Received: from mga03.intel.com ([134.134.136.65]:40706 "EHLO mga03.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750821AbbF2Hg7 (ORCPT ); Mon, 29 Jun 2015 03:36:59 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,697,1427785200"; d="scan'208";a="596531838" Date: Mon, 29 Jun 2015 10:36:56 +0300 From: Vlad Dogaru To: Geert Uytterhoeven Cc: Jonathan Cameron , linux-iio@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH] iio: sx9500: Add missing init in sx9500_buffer_pre{en,dis}able() Message-ID: <20150629073655.GC12017@vdogaru> References: <1435562073-31503-1-git-send-email-geert@linux-m68k.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <1435562073-31503-1-git-send-email-geert@linux-m68k.org> User-Agent: Mutt/1.5.21 (2010-09-15) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2046 Lines: 54 On Mon, Jun 29, 2015 at 09:14:33AM +0200, Geert Uytterhoeven wrote: > drivers/iio/proximity/sx9500.c: In function ‘sx9500_buffer_preenable’: > drivers/iio/proximity/sx9500.c:682: warning: ‘ret’ may be used uninitialized in this function > drivers/iio/proximity/sx9500.c: In function ‘sx9500_buffer_predisable’: > drivers/iio/proximity/sx9500.c:706: warning: ‘ret’ may be used uninitialized in this function > > If active_scan_mask is empty, it will loop once more over all channels, > doing nothing. > > Signed-off-by: Geert Uytterhoeven Reviewed-by: Vlad Dogaru I wonder if those functions are ever called with an empty scan mask. But the fix is correct nonetheless. Nice catch :) > --- > drivers/iio/proximity/sx9500.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/iio/proximity/sx9500.c b/drivers/iio/proximity/sx9500.c > index 2042e375f8351de6..7624cfa2422d4e41 100644 > --- a/drivers/iio/proximity/sx9500.c > +++ b/drivers/iio/proximity/sx9500.c > @@ -679,7 +679,7 @@ out: > static int sx9500_buffer_preenable(struct iio_dev *indio_dev) > { > struct sx9500_data *data = iio_priv(indio_dev); > - int ret, i; > + int ret = 0, i; > > mutex_lock(&data->mutex); > > @@ -703,7 +703,7 @@ static int sx9500_buffer_preenable(struct iio_dev *indio_dev) > static int sx9500_buffer_predisable(struct iio_dev *indio_dev) > { > struct sx9500_data *data = iio_priv(indio_dev); > - int ret, i; > + int ret = 0, i; > > iio_triggered_buffer_predisable(indio_dev); > > -- > 1.9.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-iio" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/