Message-ID: <5590F946.8040507@vodafone.de>
Date: Mon, 29 Jun 2015 09:52:38 +0200
From: =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= <deathsimple@vodafone.de>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0
MIME-Version: 1.0
To: Alexander Kuleshov <kuleshovmail@gmail.com>,
        David Airlie <airlied@linux.ie>,
        =?UTF-8?B?Q2hyaXN0aWFuIEvDtm5pZw==?= <christian.koenig@amd.com>,
        Alex Deucher <alexander.deucher@amd.com>,
        Jammy Zhou <Jammy.Zhou@amd.com>, "monk.liu" <monk.liu@amd.com>,
        =?UTF-8?B?TWFyZWsgT2zFocOhaw==?= <marek.olsak@amd.com>
CC: linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org
Subject: Re: [PATCH] gpu/drm/amdgpu: Fix build when CONFIG_DEBUG_FS is not
 set
References: <1435389365-1594-1-git-send-email-kuleshovmail@gmail.com>
In-Reply-To: <1435389365-1594-1-git-send-email-kuleshovmail@gmail.com>
Content-Type: text/plain; charset=utf-8; format=flowed
Content-Transfer-Encoding: 8bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1709
Lines: 46

On 27.06.2015 09:16, Alexander Kuleshov wrote:
> If the CONFIG_DEBUG_FS is not selected, compilation of the
> drivers/gpu/drm/amd/amdgpu/amdgpu_device.c provides two warnings that
> amdgpu_debugfs_regs_init and amdgpu_debugfs_regs_cleanup are used but
> never defined. And as result:
>
> ERROR: "amdgpu_debugfs_regs_cleanup" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
> ERROR: "amdgpu_debugfs_regs_init" [drivers/gpu/drm/amd/amdgpu/amdgpu.ko] undefined!
>              ^
>
> Signed-off-by: Alexander Kuleshov <kuleshovmail@gmail.com>

Reviewed-by: Christian König <christian.koenig@amd.com>

> ---
>   drivers/gpu/drm/amd/amdgpu/amdgpu_device.c | 6 ++++++
>   1 file changed, 6 insertions(+)
>
> diff --git a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> index fec487d..6896798 100644
> --- a/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> +++ b/drivers/gpu/drm/amd/amdgpu/amdgpu_device.c
> @@ -2000,5 +2000,10 @@ int amdgpu_debugfs_init(struct drm_minor *minor)
>   void amdgpu_debugfs_cleanup(struct drm_minor *minor)
>   {
>   }
> +#else
> +static int amdgpu_debugfs_regs_init(struct amdgpu_device *adev)
> +{
> +	return 0;
> +}
> +static void amdgpu_debugfs_regs_cleanup(struct amdgpu_device *adev) { }
>   #endif
> --
> 2.4.4.410.gc71d752
>
> _______________________________________________
> dri-devel mailing list
> dri-devel@lists.freedesktop.org
> http://lists.freedesktop.org/mailman/listinfo/dri-devel

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/