Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752461AbbF2IBw (ORCPT ); Mon, 29 Jun 2015 04:01:52 -0400 Received: from mail1.bemta14.messagelabs.com ([193.109.254.107]:38498 "EHLO mail1.bemta14.messagelabs.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752075AbbF2IBm (ORCPT ); Mon, 29 Jun 2015 04:01:42 -0400 X-Env-Sender: stwiss.opensource@diasemi.com X-Msg-Ref: server-12.tower-193.messagelabs.com!1435564897!27385791!1 X-Originating-IP: [94.185.165.51] X-StarScan-Received: X-StarScan-Version: 6.13.16; banners=-,-,- X-VirusChecked: Checked From: "Opensource [Steve Twiss]" To: Lee Jones CC: LINUXKERNEL , Samuel Ortiz , Alessandro Zummo , DEVICETREE , David Dajun Chen , Dmitry Torokhov , Ian Campbell , Kumar Gala , LINUXINPUT , LINUXWATCHDOG , Liam Girdwood , "Mark Brown" , Mark Rutland , Pawel Moll , RTCLINUX , Rob Herring , Support Opensource , Wim Van Sebroeck Subject: RE: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver Thread-Topic: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver Thread-Index: AQHQkje+BbbztfyjIkOz27ag7HsO6Z2OZ74AgALzVjCAFbuuAP///SqAgBxDg+A= Date: Mon, 29 Jun 2015 08:01:36 +0000 Message-ID: <6ED8E3B22081A4459DAC7699F3695FB7014B233463@SW-EX-MBX02.diasemi.com> References: <20150526161024.GQ11677@x1> <6ED8E3B22081A4459DAC7699F3695FB7014B22F4C4@SW-EX-MBX02.diasemi.com> <20150611085653.GG2982@x1> In-Reply-To: <20150611085653.GG2982@x1> Accept-Language: en-GB, en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.20.26.77] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id t5T820xF004628 Content-Length: 1472 Lines: 39 On 11 June 2015 09:57, Lee Jones wrote: > To: Opensource [Steve Twiss] > Subject: Re: [PATCH V3 1/4] mfd: da9062: DA9062 MFD core driver > > > > > > Steve Twiss wrote: > > > > > +#define DA9062AA_PAGE_SHIFT 0 > > > > > +#define DA9062AA_PAGE_MASK (0x3f << 0) > > > > > +#define DA9062AA_WRITE_MODE_SHIFT 6 > > > > > +#define DA9062AA_WRITE_MODE_MASK (0x01 << 6) > > > > > > > > Lee Jones wrote: > > > > For 1 << X, you should use BIT(X). > > > > > > Steve Twiss wrote: > > > The whole of this file is automatically generated by our hardware designers > > > I would prefer it if the register definitions and bit fields are not altered [...] [...] > Lee Jones wrote: > To be honest, it's probably not a blocker for acceptance, but if someone > writes a patch next week to change all of the (0x01 << X) lines to > start using the BIT() macro, I will accept it. Better to influenced > your guys so you are not overly inconvenienced. > FWIW, when upstreaming code, the excuse "someone else wrote it", has > never been a good one to use on the lists. Believe me, I've > tried. ;) Hi Lee, Depending on your next step .. I can either send a patch to this now or wait until you have reviewed the MFD core: if there are any further comments on this, I can update the submission retrospectively. Regards, Steve ????{.n?+???????+%?????ݶ??w??{.n?+????{??G?????{ay?ʇڙ?,j??f???h?????????z_??(?階?ݢj"???m??????G????????????&???~???iO???z??v?^?m???? ????????I?