Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752812AbbF2IZi (ORCPT ); Mon, 29 Jun 2015 04:25:38 -0400 Received: from mail-wi0-f179.google.com ([209.85.212.179]:33301 "EHLO mail-wi0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750811AbbF2IZc (ORCPT ); Mon, 29 Jun 2015 04:25:32 -0400 Message-ID: <1435566329.2900.1.camel@gmail.com> Subject: Re: [all better] Re: regression: massive trouble with fpu rework From: Mike Galbraith To: Ingo Molnar Cc: Ingo Molnar , LKML , Borislav Petkov , "H. Peter Anvin" , Thomas Gleixner , Andy Lutomirski , Denys Vlasenko , Oleg Nesterov , Dave Hansen Date: Mon, 29 Jun 2015 10:25:29 +0200 In-Reply-To: <20150629064008.GA16251@gmail.com> References: <1435386316.3664.23.camel@gmail.com> <1435393129.3490.7.camel@gmail.com> <20150627082514.GA10894@gmail.com> <1435395328.6545.10.camel@gmail.com> <20150629064008.GA16251@gmail.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1215 Lines: 44 On Mon, 2015-06-29 at 08:40 +0200, Ingo Molnar wrote: > * > Ok, so could you please move the fpu__init_system() further up and see which > position is that starts breaking with the BIOS option set? > > here's the current, broken layout of the code: > > get_cpu_cap(c); > [0] fpu__init_system(c); > > if (this_cpu->c_early_init) > this_cpu->c_early_init(c); > > [1] > c->cpu_index = 0; > [2] > filter_cpuid_features(c, false); > > [3] > if (this_cpu->c_bsp_init) > this_cpu->c_bsp_init(c); > > [4] > setup_force_cpu_cap(X86_FEATURE_ALWAYS); > [5] > } > > and we know it from your testing that moving [0] to [5] fixes the crash. > > The question is, can we move it to [4], [3], [2] or even [1] instead, without > breaking the system? > > I still don't see where the breakage comes from, but this would help us narrow it > down. [0] is the only spot that breaks box. -Mike -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/