Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753095AbbF2Irc (ORCPT ); Mon, 29 Jun 2015 04:47:32 -0400 Received: from mail-wg0-f53.google.com ([74.125.82.53]:35755 "EHLO mail-wg0-f53.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752309AbbF2IrX (ORCPT ); Mon, 29 Jun 2015 04:47:23 -0400 Message-ID: <5591061F.9040008@linaro.org> Date: Mon, 29 Jun 2015 10:47:27 +0200 From: Daniel Lezcano User-Agent: Mozilla/5.0 (X11; Linux i686; rv:31.0) Gecko/20100101 Thunderbird/31.6.0 MIME-Version: 1.0 To: Viresh Kumar , Thomas Gleixner CC: linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 1/7] clockevents: Allow set-state callbacks to be optional References: <2e6dadb011755d94fa88482e67641c7d9dfff67d.1434095303.git.viresh.kumar@linaro.org> In-Reply-To: <2e6dadb011755d94fa88482e67641c7d9dfff67d.1434095303.git.viresh.kumar@linaro.org> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1197 Lines: 32 On 06/12/2015 10:00 AM, Viresh Kumar wrote: > Its mandatory for the drivers to provide set_state_{oneshot|periodic}() > (only if related modes are supported) and set_state_shutdown() callbacks > today, if they are implementing the new set-state interface. > > But this leads to unnecessary noop callbacks for drivers which don't > want to implement them. Over that, it will lead to a full function call > for nothing really useful. > > Lets make all set-state callbacks optional. > > Suggested-by: Daniel Lezcano > Signed-off-by: Viresh Kumar As this patch is needed for the other changes in this patchset, is it possible to take it through my tree Thomas ? -- Linaro.org │ Open source software for ARM SoCs Follow Linaro: Facebook | Twitter | Blog -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/