Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752814AbbF2JPh (ORCPT ); Mon, 29 Jun 2015 05:15:37 -0400 Received: from www.linutronix.de ([62.245.132.108]:57068 "EHLO Galois.linutronix.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753240AbbF2JP2 (ORCPT ); Mon, 29 Jun 2015 05:15:28 -0400 Date: Mon, 29 Jun 2015 11:15:23 +0200 (CEST) From: Thomas Gleixner To: Daniel Lezcano cc: Viresh Kumar , linaro-kernel@lists.linaro.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH V2 1/7] clockevents: Allow set-state callbacks to be optional In-Reply-To: <5591061F.9040008@linaro.org> Message-ID: References: <2e6dadb011755d94fa88482e67641c7d9dfff67d.1434095303.git.viresh.kumar@linaro.org> <5591061F.9040008@linaro.org> User-Agent: Alpine 2.11 (DEB 23 2013-08-11) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII X-Linutronix-Spam-Score: -1.0 X-Linutronix-Spam-Level: - X-Linutronix-Spam-Status: No , -1.0 points, 5.0 required, ALL_TRUSTED=-1,SHORTCIRCUIT=-0.0001,URIBL_BLOCKED=0.001 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1154 Lines: 30 On Mon, 29 Jun 2015, Daniel Lezcano wrote: > On 06/12/2015 10:00 AM, Viresh Kumar wrote: > > Its mandatory for the drivers to provide set_state_{oneshot|periodic}() > > (only if related modes are supported) and set_state_shutdown() callbacks > > today, if they are implementing the new set-state interface. > > > > But this leads to unnecessary noop callbacks for drivers which don't > > want to implement them. Over that, it will lead to a full function call > > for nothing really useful. > > > > Lets make all set-state callbacks optional. > > > > Suggested-by: Daniel Lezcano > > Signed-off-by: Viresh Kumar > > As this patch is needed for the other changes in this patchset, is it possible > to take it through my tree Thomas ? I have not other dependencies in that area ATM, so it can bake in yours and I'll pull it over then. Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/