Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752531AbbF2LQ4 (ORCPT ); Mon, 29 Jun 2015 07:16:56 -0400 Received: from cantor2.suse.de ([195.135.220.15]:46873 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752612AbbF2LQz (ORCPT ); Mon, 29 Jun 2015 07:16:55 -0400 Date: Mon, 29 Jun 2015 13:16:51 +0200 (CEST) From: Jiri Kosina To: Oliver Neukum cc: Greg Kroah-Hartman , Alan Stern , Tom Gundersen , linux-usb@vger.kernel.org, linux-input@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices In-Reply-To: <1435571292.1805.4.camel@suse.com> Message-ID: References: <20150626221517.GB2761@kroah.com> <20150627012959.GA15207@kroah.com> <1435571292.1805.4.camel@suse.com> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1116 Lines: 29 On Mon, 29 Jun 2015, Oliver Neukum wrote: > > Last time we were testing this, autosuspend for USB HID devices was quite > > a disaster. > > > > Do you have any idea whether udev developers tested the "autosuspend on by > > default for USB HID devices" on reasonable set of devices? > > > > The culrpits that I remember from top of my head (it's been long time > > ago): > > > > - the LEDs for suspended device go off. This is very confusing at least on > > keyboards, and brings really bad user experience > > That is a bug. hidinput_count_leds() is supposed to prevent that. This is a HW property and nothing kernel can do about. I am not saying it doesn't bring the LEDs up to a proper state again once auto-resumed. But I hate the LEDs going off a few seconds after I stop typing (i.e. once the keyboard gets auto-suspended). -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/