Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753224AbbF2LYm (ORCPT ); Mon, 29 Jun 2015 07:24:42 -0400 Received: from mail-ob0-f173.google.com ([209.85.214.173]:35087 "EHLO mail-ob0-f173.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752043AbbF2LYc (ORCPT ); Mon, 29 Jun 2015 07:24:32 -0400 MIME-Version: 1.0 In-Reply-To: <1434594513.26032.6.camel@mtksdaap41> References: <1434367253-26577-1-git-send-email-chaotian.jing@mediatek.com> <1434367253-26577-5-git-send-email-chaotian.jing@mediatek.com> <1434593063.23303.3.camel@mtksdaap41> <1434594513.26032.6.camel@mtksdaap41> From: Daniel Kurtz Date: Mon, 29 Jun 2015 19:24:12 +0800 X-Google-Sender-Auth: DmYFod_vdyRkywrjzcjtbQaYbCQ Message-ID: Subject: Re: [PATCH v6 4/7] arm64: dts: mediatek: Add MT8173 MMC dts To: Eddie Huang Cc: Chaotian Jing , Rob Herring , Matthias Brugger , Chris Ball , Ulf Hansson , Mark Rutland , James Liao , Russell King - ARM Linux , srv_heupstream , Arnd Bergmann , "open list:OPEN FIRMWARE AND..." , Hongzhou Yang , Catalin Marinas , bin.zhang@mediatek.com, linux-mmc@vger.kernel.org, "linux-kernel@vger.kernel.org" , Will Deacon , linux-gpio@vger.kernel.org, linux-mediatek@lists.infradead.org, Sascha Hauer , "Joe.C" , "linux-arm-kernel@lists.infradead.org" , Henry Chen Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3069 Lines: 92 On Thu, Jun 18, 2015 at 10:28 AM, Eddie Huang wrote: > > Hi Dan, > > On Thu, 2015-06-18 at 10:04 +0800, Eddie Huang wrote: > > Hi Dan, > > > > On Tue, 2015-06-16 at 20:20 +0800, Daniel Kurtz wrote: > > > On Tue, Jun 16, 2015 at 7:39 PM, Daniel Kurtz wrote: > > > > On Mon, Jun 15, 2015 at 7:20 PM, Chaotian Jing > > > > wrote: > > > >> From: Eddie Huang > > > >> > > > >> Add node mmc0 ~ mmc3 for mt8173.dtsi > > > >> Add node mmc0, mmc1 for mt8173-evb.dts > > > >> > > > >> Signed-off-by: Chaotian Jing > > > >> Signed-off-by: Eddie Huang > > > >> --- > > > >> arch/arm64/boot/dts/mediatek/mt8173-evb.dts | 126 ++++++++++++++++++++++++++++ > > > >> arch/arm64/boot/dts/mediatek/mt8173.dtsi | 45 +++++++++- > > > >> 2 files changed, 170 insertions(+), 1 deletion(-) > > > >> > > > >> diff --git a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > > > >> index b1560c9..762ec61 100644 > > > >> --- a/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > > > >> +++ b/arch/arm64/boot/dts/mediatek/mt8173-evb.dts > > > >> @@ -33,6 +33,132 @@ > > > >> chosen { }; > > > >> }; > > > >> > > > >> +&mmc0 { > > > >> + pinctrl-names = "default", "state_uhs"; > > > >> + pinctrl-0 = <&mmc0_pins_default>; > > > >> + pinctrl-1 = <&mmc0_pins_uhs>; > > > >> + status = "okay"; > > > >> + bus-width = <8>; > > > >> + max-frequency = <50000000>; > > > >> + cap-mmc-highspeed; > > > >> + vmmc-supply = <&mt6397_vemc_3v3_reg>; > > > >> + vqmmc-supply = <&mt6397_vio18_reg>; > > > > > > I also can't find phandles for these regulators. > > > > > > >> + non-removable; > > > >> +}; > > > >> + > > > >> +&mmc1 { > > > >> + pinctrl-names = "default", "state_uhs"; > > > >> + pinctrl-0 = <&mmc1_pins_default>; > > > >> + pinctrl-1 = <&mmc1_pins_uhs>; > > > >> + status = "okay"; > > > >> + bus-width = <4>; > > > >> + max-frequency = <50000000>; > > > >> + cap-sd-highspeed; > > > >> + sd-uhs-sdr25; > > > >> + cd-gpios = <&pio 132 0>; > > > >> + vmmc-supply = <&mt6397_vmch_reg>; > > > >> + vqmmc-supply = <&mt6397_vmc_reg>; > > > > > > nor these regulators. > > > > > > Which kernel branch are you basing your patch set on? > > > > > It is based on 4.1-rc1, and Sascha's regulator dts patch. > > [3/4] ARM: dts: mt8135-evbp1: Add PMIC support: > > https://patchwork.kernel.org/patch/6261161/ > > > My mistake, we only sent mt8135-evbp1.dts, but this patch need > mt8173-evb.dts, we will send this. Hi Eddie, When do you plan to send an updated mmc patch set? Thanks, -Dan > > > Eddie > Thanks > > > > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/