Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752755AbbF2Li1 (ORCPT ); Mon, 29 Jun 2015 07:38:27 -0400 Received: from cantor2.suse.de ([195.135.220.15]:48165 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752627AbbF2LiU (ORCPT ); Mon, 29 Jun 2015 07:38:20 -0400 Message-ID: <1435577839.1805.10.camel@suse.de> Subject: Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices From: Oliver Neukum To: Jiri Kosina Cc: Tom Gundersen , Greg Kroah-Hartman , Alan Stern , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Date: Mon, 29 Jun 2015 13:37:19 +0200 In-Reply-To: References: <20150626221517.GB2761@kroah.com> <20150627012959.GA15207@kroah.com> <1435571292.1805.4.camel@suse.com> Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.12.11 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1293 Lines: 35 On Mon, 2015-06-29 at 13:16 +0200, Jiri Kosina wrote: > On Mon, 29 Jun 2015, Oliver Neukum wrote: > > > > Last time we were testing this, autosuspend for USB HID devices was quite > > > a disaster. > > > > > > Do you have any idea whether udev developers tested the "autosuspend on by > > > default for USB HID devices" on reasonable set of devices? > > > > > > The culrpits that I remember from top of my head (it's been long time > > > ago): > > > > > > - the LEDs for suspended device go off. This is very confusing at least on > > > keyboards, and brings really bad user experience > > > > That is a bug. hidinput_count_leds() is supposed to prevent that. > > This is a HW property and nothing kernel can do about. I am not saying it > doesn't bring the LEDs up to a proper state again once auto-resumed. But I > hate the LEDs going off a few seconds after I stop typing (i.e. once the > keyboard gets auto-suspended). That is the point. Unless you give the option to override, they shouldn't autosuspend. Regards Oliver -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/