Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752775AbbF2MB2 (ORCPT ); Mon, 29 Jun 2015 08:01:28 -0400 Received: from mail.emea.novell.com ([130.57.118.101]:51214 "EHLO mail.emea.novell.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752172AbbF2MBV (ORCPT ); Mon, 29 Jun 2015 08:01:21 -0400 Date: Mon, 29 Jun 2015 14:00:59 +0200 (CEST) From: Jiri Kosina X-X-Sender: jkosina@pobox.suse.cz To: Oliver Neukum cc: Tom Gundersen , Greg Kroah-Hartman , Alan Stern , linux-input@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org Subject: Re: [PATCH][RFC] usbhid: enable autosuspend for internal devices In-Reply-To: <1435577839.1805.10.camel@suse.de> Message-ID: References: <20150626221517.GB2761@kroah.com> <20150627012959.GA15207@kroah.com> <1435571292.1805.4.camel@suse.com> <1435577839.1805.10.camel@suse.de> User-Agent: Alpine 2.00 (LNX 1167 2008-08-23) MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 816 Lines: 21 On Mon, 29 Jun 2015, Oliver Neukum wrote: > > This is a HW property and nothing kernel can do about. I am not saying it > > doesn't bring the LEDs up to a proper state again once auto-resumed. But I > > hate the LEDs going off a few seconds after I stop typing (i.e. once the > > keyboard gets auto-suspended). > > That is the point. Unless you give the option to override, they > shouldn't autosuspend. Ah, you're right, I completely forgot about the logic we've put into hidinput_count_leds() quite some time ago. Sorry for the noise, -- Jiri Kosina SUSE Labs -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/