Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752508AbbF2MrN (ORCPT ); Mon, 29 Jun 2015 08:47:13 -0400 Received: from mail-wg0-f45.google.com ([74.125.82.45]:34706 "EHLO mail-wg0-f45.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752522AbbF2MrG (ORCPT ); Mon, 29 Jun 2015 08:47:06 -0400 Message-ID: <55913E36.4010407@linaro.org> Date: Mon, 29 Jun 2015 14:46:46 +0200 From: Eric Auger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: jroedel@suse.de, Will Deacon , Baptiste Reynal , Alex Williamson , "linux-kernel@vger.kernel.org" Subject: Regression observed since "iommu: Propagate error in add_iommu_group" with arm-smmu Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1364 Lines: 40 Hi Joerg, Will I observe a regression since commit 19762d7095e6392b6ec56c363a6f29b2119488c2 (iommu: Propagate error in add_iommu_group) with arm-smmu: I am not able to bind the vfio-platform driver to one Calxeda Midway xgmac anymore. This latter is not assigned any group. Looks like the cause is, in iommu_bus_init, when doing bus_for_each_dev(bus, NULL, &cb, add_iommu_group), add_iommu_group fails for some devices which are not upstream to smmu and enumerated before the xgmac. As a consequence bus_for_each_dev returns without looking at the xgmac. arm_smmu_add_platform_device currently returns -ENODEV when no smmu/no master port for the device. Shouldn't we return 0 now? Thank you in advance Best Regards Eric 19762d7095e6392b6ec56c363a6f29b2119488c2 is the first bad commit commit 19762d7095e6392b6ec56c363a6f29b2119488c2 Author: Joerg Roedel Date: Thu May 28 18:41:26 2015 +0200 iommu: Propagate error in add_iommu_group Make sure any errors reported from the IOMMU drivers get progapated back to the IOMMU core. Signed-off-by: Joerg Roedel -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/