Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752379AbbF2NdO (ORCPT ); Mon, 29 Jun 2015 09:33:14 -0400 Received: from mail-wi0-f178.google.com ([209.85.212.178]:34557 "EHLO mail-wi0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752821AbbF2NdH (ORCPT ); Mon, 29 Jun 2015 09:33:07 -0400 Message-ID: <55914900.1070908@linaro.org> Date: Mon, 29 Jun 2015 15:32:48 +0200 From: Eric Auger User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Joerg Roedel CC: Will Deacon , Baptiste Reynal , Alex Williamson , "linux-kernel@vger.kernel.org" Subject: Re: Regression observed since "iommu: Propagate error in add_iommu_group" with arm-smmu References: <55913E36.4010407@linaro.org> <20150629131656.GB16648@suse.de> In-Reply-To: <20150629131656.GB16648@suse.de> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1531 Lines: 46 Hi Joerg, On 06/29/2015 03:16 PM, Joerg Roedel wrote: > Hi Eric > > On Mon, Jun 29, 2015 at 02:46:46PM +0200, Eric Auger wrote: >> Hi Joerg, Will >> >> I observe a regression since commit >> 19762d7095e6392b6ec56c363a6f29b2119488c2 (iommu: Propagate error in >> add_iommu_group) with arm-smmu: I am not able to bind the vfio-platform >> driver to one Calxeda Midway xgmac anymore. This latter is not assigned >> any group. >> >> Looks like the cause is, in iommu_bus_init, when doing >> bus_for_each_dev(bus, NULL, &cb, add_iommu_group), >> add_iommu_group fails for some devices which are not upstream to smmu >> and enumerated before the xgmac. As a consequence bus_for_each_dev >> returns without looking at the xgmac. >> >> arm_smmu_add_platform_device currently returns -ENODEV when no smmu/no >> master port for the device. Shouldn't we return 0 now? > > I posted a patch today which fixes this by ignoring -ENODEV as a return > value in add_iommu_group. See here: > > http://lists.linuxfoundation.org/pipermail/iommu/2015-June/013508.html > > I'll send this fix upstream asap (means: tomorrow). It would be great if > you can test it too in your setup. Great. yes it works fine with my setup! Tested-by: Eric Auger Thanks Eric > > > Joerg > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/