Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752974AbbF2Odk (ORCPT ); Mon, 29 Jun 2015 10:33:40 -0400 Received: from mail.kernel.org ([198.145.29.136]:52038 "EHLO mail.kernel.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750904AbbF2Ode (ORCPT ); Mon, 29 Jun 2015 10:33:34 -0400 Date: Mon, 29 Jun 2015 11:33:30 -0300 From: Arnaldo Carvalho de Melo To: Wang Nan Cc: ast@plumgrid.com, brendan.d.gregg@gmail.com, daniel@iogearbox.net, namhyung@kernel.org, masami.hiramatsu.pt@hitachi.com, paulus@samba.org, a.p.zijlstra@chello.nl, mingo@redhat.com, jolsa@kernel.org, dsahern@gmail.com, linux-kernel@vger.kernel.org, lizefan@huawei.com, hekuang@huawei.com, xiakaixu@huawei.com, pi3orama@163.com Subject: Re: [RFC PATCH v9 49/50 -fix] perf probe: Init symbol as kprobe if any event is kprobe Message-ID: <20150629143330.GE11747@kernel.org> References: <1435328155-87115-50-git-send-email-wangnan0@huawei.com> <1435407945-23468-1-git-send-email-wangnan0@huawei.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1435407945-23468-1-git-send-email-wangnan0@huawei.com> X-Url: http://acmel.wordpress.com User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1720 Lines: 47 Em Sat, Jun 27, 2015 at 12:25:45PM +0000, Wang Nan escreveu: > Before this patch, add_perf_probe_events() init symbol maps only for > uprobe if the first 'struct perf_probe_event' passed to it is a uprobe > event. This is a trick because 'perf probe''s command line syntax > constrains the first elements of the probe_event arrays must be kprobes > if there is one. > > However, with the incoming BPF uprobe support, the constrain is not > hold since 'perf record' will also probe on k/u probes through BPF > object, and is possible to pass an array with kprobe but the first > element is uprobe. > > This patch init symbol maps for kprobes even if all of events are > uprobes, because the extra cost should be small enough. > > Signed-off-by: Wang Nan > --- Please add more info here, i.e. is this to be applied on top of the original 49/50? I guess so, but please state this in the future to speed things up. - Arnaldo > tools/perf/util/probe-event.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/tools/perf/util/probe-event.c b/tools/perf/util/probe-event.c > index ea08015..e74ca8f 100644 > --- a/tools/perf/util/probe-event.c > +++ b/tools/perf/util/probe-event.c > @@ -2804,7 +2804,7 @@ int add_perf_probe_events(struct perf_probe_event *pevs, int npevs, > { > int i, ret; > > - ret = init_symbol_maps(pevs->uprobes); > + ret = init_symbol_maps(false); > if (ret < 0) > return ret; > > -- > 1.8.3.4 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/