Message-id: <559159C2.40305@samsung.com>
Date: Mon, 29 Jun 2015 16:44:18 +0200
From: Jacek Anaszewski <j.anaszewski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804
 Thunderbird/17.0.8
MIME-version: 1.0
To: Randy Dunlap <rdunlap@infradead.org>
Cc: LKML <linux-kernel@vger.kernel.org>, linux-leds@vger.kernel.org,
        Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>
Subject: Re: [PATCH -next] leds: fix aat1290 build errors
References: <558DA144.6050203@infradead.org>
In-reply-to: <558DA144.6050203@infradead.org>
Content-type: text/plain; charset=UTF-8; format=flowed
Content-transfer-encoding: 7bit
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1487
Lines: 45

Hi Randy,

Thanks for the patch.

On 06/26/2015 09:00 PM, Randy Dunlap wrote:
> From: Randy Dunlap <rdunlap@infradead.org>
>
> Fix build errors when LEDS_AAT1290=y and V4L2_FLASH_LED_CLASS=m
> by restricting LEDS_AAT1290 to =m if V4L2_FLASH_LED_CLASS=m.
>
> drivers/built-in.o: In function `aat1290_led_remove':
> leds-aat1290.c:(.text+0xe5d77): undefined reference to `v4l2_flash_release'
> drivers/built-in.o: In function `aat1290_led_probe':
> leds-aat1290.c:(.text+0xe6494): undefined reference to `v4l2_flash_init'
>
> Signed-off-by: Randy Dunlap <rdunlap@infradead.org>
> Cc: Jacek Anaszewski <j.anaszewski@samsung.com>
> Cc: Bryan Wu <cooloney@gmail.com>
> Cc: Richard Purdie <rpurdie@rpsys.net>
> ---
>   drivers/leds/Kconfig |    1 +
>   1 file changed, 1 insertion(+)
>
> --- linux-next-20150626.orig/drivers/leds/Kconfig
> +++ linux-next-20150626/drivers/leds/Kconfig
> @@ -42,6 +42,7 @@ config LEDS_88PM860X
>   config LEDS_AAT1290
>   	tristate "LED support for the AAT1290"
>   	depends on LEDS_CLASS_FLASH
> +	depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS
>   	depends on GPIOLIB
>   	depends on OF
>   	depends on PINCTRL
>

Acked-by: Jacek Anaszewski <j.anaszewski@samsung.com>

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/