Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752604AbbF2QY4 (ORCPT ); Mon, 29 Jun 2015 12:24:56 -0400 Received: from mga01.intel.com ([192.55.52.88]:64271 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752154AbbF2QYz (ORCPT ); Mon, 29 Jun 2015 12:24:55 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.13,699,1427785200"; d="scan'208";a="516029301" Subject: Re: [PATCH] perf/x86/intel/rapl: Add support for Knights Landing (KNL) From: Dasaratharaman Chandramouli To: Stephane Eranian Cc: Peter Zijlstra , Jacob Pan Jun , Paul Mackerras , Ingo Molnar , Arnaldo Carvalho de Melo , Thomas Gleixner , "H. Peter Anvin" , x86 , LKML , Nikhil Rao In-Reply-To: <1435006562.15776.3.camel@localhost> References: <20150529115543.GP3644@twins.programming.kicks-ass.net> <1435006562.15776.3.camel@localhost> Content-Type: text/plain; charset="UTF-8" Date: Mon, 29 Jun 2015 09:37:57 -0700 Message-ID: <1435595877.9457.5.camel@localhost> Mime-Version: 1.0 X-Mailer: Evolution 2.28.3 (2.28.3-30.el6) Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3249 Lines: 83 On Mon, 2015-06-22 at 13:56 -0700, Dasaratharaman Chandramouli wrote: > On Mon, 2015-06-22 at 11:52 -0700, Stephane Eranian wrote: > > On Fri, May 29, 2015 at 4:55 AM, Peter Zijlstra wrote: > > > > > > On Tue, May 26, 2015 at 11:47:39AM -0700, Dasaratharaman Chandramouli wrote: > > > > Knights Landing DRAM RAPL supports PKG and DRAM RAPL domains. > > > > DRAM RAPL has a different fixed energy unit (2^-16J) similar to > > > > that of HSW. > > > > > > > > > > Please also Cc the author of the code you're patching. > > > > > > Cc: Stephane Eranian > > > > Signed-off-by: Dasaratharaman Chandramouli > > > > --- > > > > arch/x86/kernel/cpu/perf_event_intel_rapl.c | 20 ++++++++++++++++++++ > > > > 1 file changed, 20 insertions(+) > > > > > > > > diff --git a/arch/x86/kernel/cpu/perf_event_intel_rapl.c b/arch/x86/kernel/cpu/perf_event_intel_rapl.c > > > > index 999289b9..96633fb 100644 > > > > --- a/arch/x86/kernel/cpu/perf_event_intel_rapl.c > > > > +++ b/arch/x86/kernel/cpu/perf_event_intel_rapl.c > > > > @@ -86,6 +86,10 @@ static const char *rapl_domain_names[NR_RAPL_DOMAINS] __initconst = { > > > > 1< > > > 1< > > > > > > > +/* Knights Landing has PKG, RAM */ > > > > +#define RAPL_IDX_KNL (1< > > > + 1< > > > + > > > > /* > > > > * event code: LSB 8 bits, passed in attr->config > > > > * any other bit is reserved > > > > @@ -487,6 +491,18 @@ static struct attribute *rapl_events_hsw_attr[] = { > > > > NULL, > > > > }; > > > > > > > > +static struct attribute *rapl_events_knl_attr[] = { > > > > + EVENT_PTR(rapl_pkg), > > > > + EVENT_PTR(rapl_ram), > > > > + > > > > + EVENT_PTR(rapl_pkg_unit), > > > > + EVENT_PTR(rapl_ram_unit), > > > > + > > > > + EVENT_PTR(rapl_pkg_scale), > > > > + EVENT_PTR(rapl_ram_scale), > > > > + NULL, > > > > +}; > > > > + > > > > static struct attribute_group rapl_pmu_events_group = { > > > > .name = "events", > > > > .attrs = NULL, /* patched at runtime */ > > > > @@ -730,6 +746,10 @@ static int __init rapl_pmu_init(void) > > > > rapl_cntr_mask = RAPL_IDX_SRV; > > > > rapl_pmu_events_group.attrs = rapl_events_srv_attr; > > > > break; > > > > + case 87: /* Knights Landing */ > > > > + rapl_add_quirk(rapl_hsw_server_quirk); > > > > > > Does KNL also have different raw units for RAM requiring the use of the quirk? > > That is right. KNL's DRAM has a different fixed energy unit (2^-16J) > similar to that of HSW Stepane, if there are no more comments/questions, could i get an ack? > > > > > > > > > > + rapl_cntr_mask = RAPL_IDX_KNL; > > > > + rapl_pmu_events_group.attrs = rapl_events_knl_attr; > > > > > > break; > > > > > > ? > -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/