Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752744AbbF2QiO (ORCPT ); Mon, 29 Jun 2015 12:38:14 -0400 Received: from mail-gw2-out.broadcom.com ([216.31.210.63]:6267 "EHLO mail-gw2-out.broadcom.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751850AbbF2QiG (ORCPT ); Mon, 29 Jun 2015 12:38:06 -0400 X-IronPort-AV: E=Sophos;i="5.13,699,1427785200"; d="scan'208";a="68654482" Message-ID: <5591746A.80300@broadcom.com> Date: Mon, 29 Jun 2015 09:38:02 -0700 From: Ray Jui User-Agent: Mozilla/5.0 (Windows NT 6.1; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Florian Fainelli , Scott Branden , Russell King CC: , , Subject: Re: [PATCH] ARM: BCM: Enable NAND support for iProc SoCs References: <1432861754-26606-1-git-send-email-rjui@broadcom.com> <558DBC53.3050100@gmail.com> In-Reply-To: <558DBC53.3050100@gmail.com> Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1371 Lines: 36 Hi Florian, On 6/26/2015 1:55 PM, Florian Fainelli wrote: > On 28/05/15 18:09, Ray Jui wrote: >> Select CONFIG_MTD_NAND_BRCMNAND for all iProc SoCs > > In fact, this patch creates an unmet dependency problem, we also need to > select MTD and MTD_NAND otherwise we run into a linking error while > building the brcmnand driver: > > LD init/built-in.o > drivers/built-in.o: In function `brcmnand_remove': > /home/fainelli/dev/linux/drivers/mtd/nand/brcmnand/brcmnand.c:2234: > undefined reference to `nand_release' > drivers/built-in.o: In function `brcmnand_init_cs': > /home/fainelli/dev/linux/drivers/mtd/nand/brcmnand/brcmnand.c:1933: > undefined reference to `nand_scan_ident' > /home/fainelli/dev/linux/drivers/mtd/nand/brcmnand/brcmnand.c:1958: > undefined reference to `nand_scan_tail' > Makefile:931: recipe for target 'vmlinux' failed > make: *** [vmlinux] Error 1 > > I will take care of that and send a fix for 4.2. > When I tested this, I tested against multi_v7_defconfig where MTD and MTD_NAND were enabled in the defconfig, so I did not see this problem. Thanks a lot for helping to fix this. Ray -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/