Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751159AbbF2RJT (ORCPT ); Mon, 29 Jun 2015 13:09:19 -0400 Received: from mail-yk0-f179.google.com ([209.85.160.179]:32778 "EHLO mail-yk0-f179.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752627AbbF2RJL (ORCPT ); Mon, 29 Jun 2015 13:09:11 -0400 MIME-Version: 1.0 In-Reply-To: <559159C2.40305@samsung.com> References: <558DA144.6050203@infradead.org> <559159C2.40305@samsung.com> From: Bryan Wu Date: Mon, 29 Jun 2015 10:08:50 -0700 Message-ID: Subject: Re: [PATCH -next] leds: fix aat1290 build errors To: Jacek Anaszewski Cc: Randy Dunlap , LKML , Linux LED Subsystem , Richard Purdie Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1665 Lines: 51 On Mon, Jun 29, 2015 at 7:44 AM, Jacek Anaszewski wrote: > Hi Randy, > > Thanks for the patch. > > > On 06/26/2015 09:00 PM, Randy Dunlap wrote: >> >> From: Randy Dunlap >> >> Fix build errors when LEDS_AAT1290=y and V4L2_FLASH_LED_CLASS=m >> by restricting LEDS_AAT1290 to =m if V4L2_FLASH_LED_CLASS=m. >> >> drivers/built-in.o: In function `aat1290_led_remove': >> leds-aat1290.c:(.text+0xe5d77): undefined reference to >> `v4l2_flash_release' >> drivers/built-in.o: In function `aat1290_led_probe': >> leds-aat1290.c:(.text+0xe6494): undefined reference to `v4l2_flash_init' >> >> Signed-off-by: Randy Dunlap >> Cc: Jacek Anaszewski >> Cc: Bryan Wu >> Cc: Richard Purdie >> --- >> drivers/leds/Kconfig | 1 + >> 1 file changed, 1 insertion(+) >> >> --- linux-next-20150626.orig/drivers/leds/Kconfig >> +++ linux-next-20150626/drivers/leds/Kconfig >> @@ -42,6 +42,7 @@ config LEDS_88PM860X >> config LEDS_AAT1290 >> tristate "LED support for the AAT1290" >> depends on LEDS_CLASS_FLASH >> + depends on V4L2_FLASH_LED_CLASS || !V4L2_FLASH_LED_CLASS >> depends on GPIOLIB >> depends on OF >> depends on PINCTRL >> > > Acked-by: Jacek Anaszewski > Good fix. thanks. I merged into my tree. -Bryan -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/