Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753316AbbF2T6C (ORCPT ); Mon, 29 Jun 2015 15:58:02 -0400 Received: from mail-pd0-f172.google.com ([209.85.192.172]:36549 "EHLO mail-pd0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752640AbbF2T5z (ORCPT ); Mon, 29 Jun 2015 15:57:55 -0400 Message-ID: <5591A33B.8000209@gmail.com> Date: Tue, 30 Jun 2015 01:27:47 +0530 From: Ravi Teja Darbha User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Larry.Finger@lwfinger.net, florian.c.schilhabel@googlemail.com CC: gregkh@linuxfoundation.org, mahfouz.saif.elyazal@gmail.com, vthakkar1994@gmail.com, haggai.eran@gmail.com, sudipm.mukherjee@gmail.com, krinkin.m.u@gmail.com, krinkin.m.u@gmail.com, devel@driverdev.osuosl.org, linux-kernel@vger.kernel.org Subject: [PATCH] rtl8712:Fix checkpatch warning Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1590 Lines: 47 1. Fix line over 80 characters warning. 2. The checkpatch warning at line 499 seems to be false positive. WARNING: else is not generally useful after a break or return #499: FILE: rtl8712_recv.c:499: + return false; + else while(condition1) { if(condition2) foo(); else if(condition3) return false; else break; } The else condition here cannot be eliminated Signed-off-by: Ravi Teja Darbha --- drivers/staging/rtl8712/rtl8712_recv.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/rtl8712/rtl8712_recv.c b/drivers/staging/rtl8712/rtl8712_recv.c index fcb8c61..4fa2540 100644 --- a/drivers/staging/rtl8712/rtl8712_recv.c +++ b/drivers/staging/rtl8712/rtl8712_recv.c @@ -58,8 +58,8 @@ int r8712_init_recv_priv(struct recv_priv *precvpriv, struct _adapter *padapter) /*init recv_buf*/ _init_queue(&precvpriv->free_recv_buf_queue); - precvpriv->pallocated_recv_buf = kzalloc(NR_RECVBUFF * sizeof(struct recv_buf) + 4, - GFP_ATOMIC); + precvpriv->pallocated_recv_buf = + kzalloc(NR_RECVBUFF * sizeof(struct recv_buf) + 4, GFP_ATOMIC); if (precvpriv->pallocated_recv_buf == NULL) return _FAIL; precvpriv->precv_buf = precvpriv->pallocated_recv_buf + 4 - -- 1.9.1 -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/