Date: Mon, 29 Jun 2015 16:48:54 -0500
From: Felipe Balbi <balbi@ti.com>
To: Felipe Balbi <balbi@ti.com>, John Youn <johnyoun@synopsys.com>
CC: Subbaraya Sundeep Bhatta <subbaraya.sundeep.bhatta@xilinx.com>,
        <gregkh@linuxfoundation.org>, <linux-usb@vger.kernel.org>,
        <linux-kernel@vger.kernel.org>, <stable@vger.kernel.org>,
        Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
Subject: Re: [PATCH v2 3/3] usb: dwc3: gadget: return error if command sent
 to DEPCMD register fails
Message-ID: <20150629214854.GL1019@saruman.tx.rr.com>
Reply-To: <balbi@ti.com>
References: <1432203408-5482-1-git-send-email-sbhatta@xilinx.com>
 <1432203408-5482-3-git-send-email-sbhatta@xilinx.com>
 <20150629214701.GK1019@saruman.tx.rr.com>
MIME-Version: 1.0
Content-Type: multipart/signed; micalg=pgp-sha1;
	protocol="application/pgp-signature"; boundary="c8UbHMnQwI7BF+TB"
Content-Disposition: inline
In-Reply-To: <20150629214701.GK1019@saruman.tx.rr.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 2624
Lines: 72

--c8UbHMnQwI7BF+TB
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
Content-Transfer-Encoding: quoted-printable

Hi again,

On Mon, Jun 29, 2015 at 04:47:01PM -0500, Felipe Balbi wrote:
> On Thu, May 21, 2015 at 03:46:48PM +0530, Subbaraya Sundeep Bhatta wrote:
> > We need to return error to caller if command is not sent to
> > controller succesfully.
> >=20
> > Signed-off-by: Subbaraya Sundeep Bhatta <sbhatta@xilinx.com>
> > Fixes: 72246da40f37 (usb: Introduce DesignWare USB3 DRD Driver)
> > Cc: <stable@vger.kernel.org>
> > ---
> > v2 changes:
> > 	Added Fixes and Cc in commit message.
>=20
> I noticed that this breaks at least my AM437x silicon with DWC3 2.40a
> when used with g_zero and testusb. As of now, it could be that silicon
> is mis-behaving because I got a Transfer Complete before the failing Set
> Endpoint Transfer Resource command.
>=20
> In any case, can you run on your setup with g_zero and test.sh/testusb
> [1]/[2] just to verify that it really works for you ?
>=20
> Meanwhile, I'll continue testing on my end.
>=20
> cheers
>=20
> [1] https://gitorious.org/usb/usb-tools/source/47ef073d9b6c0eae816204c813=
74aafb795c6e40:testusb.c
> [2] https://gitorious.org/usb/usb-tools/source/47ef073d9b6c0eae816204c813=
74aafb795c6e40:test.sh

Adding John here. John, any chance you could fire up dwc3 on HAPS and
see wether it works or fails for you ?

cheers

--=20
balbi

--c8UbHMnQwI7BF+TB
Content-Type: application/pgp-signature; name="signature.asc"
Content-Description: Digital signature

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1

iQIcBAEBAgAGBQJVkb1GAAoJEIaOsuA1yqREY/oQAKU0pjvPTinTpVTKNNUTMTag
B6oN34QKURl96LquEiSo4gLSRWmGlj7C8Rc2C01/DNoXEze27uroLVpBl6o8jnj/
ykO0SgE8kOh0FIiwOgjioj9PHxEPHMO/xi6CQnpm/2sy3BCNka3tx9TzYR9pad7/
Sl5yzezJujsKQsHGpB4HQ2GjUc63ceunhNZvIt4NIvDxYoqRoDeKkfGNmygZPH1X
dVg4nY5hg2bE2KedNHKxz1kdfPUEmNmqZYY+gZmte5Buj+xQ+B92Wil/HAkHYXJv
uXYAFWmizSca0TS5VIngbsX0pEqKBiM98ZQCivrtL841xutpvZjtD5IhErG6mMAG
6ESMp10IL2hLP03DqFR/AoPWtXykb1jw6qdyumyDIiWQ/VFL4CBlvzTslImZIDLO
tJPVLDqSVJDOcoqQ23aQFNknEkrgcAnH+Viv430jdt15n+cYNBVXdH//cLxNZRL1
BgUQ7c30iIPZwtSvA75u7nbPE+SHOAKALUClzp/ffEAL5Q0vr+fqSPhv5gHR+AEi
y1d1xsR/+O7du5iwphKP2tHGJ7xP+MdPoZCZBoq/aKDwuMti0ZWvcJeoa7zQBqoG
uaT4vjcBzUjsl3OrHnmx1ov0Lm479kAVJ07QdcfVhBXtSmM8U9tleNDP+dAUBKAD
yGmfS2hPkn/wofHaq8fS
=rQ/z
-----END PGP SIGNATURE-----

--c8UbHMnQwI7BF+TB--
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/