Message-ID: <1435615884.21928.57.camel@j-VirtualBox>
Subject: Re: [PATCH 1/1] cputime: Make the reported utime+stime correspond
 to the actual runtime.
From: Jason Low <jason.low2@hp.com>
To: Fredrik =?ISO-8859-1?Q?Markstr=F6m?= <fredrik.markstrom@gmail.com>
Cc: Peter Zijlstra <peterz@infradead.org>, mingo@redhat.com,
        linux-kernel@vger.kernel.org, Rik van Riel <riel@redhat.com>,
        =?ISO-8859-1?Q?Fr=E9d=E9ric?= Weisbecker <fweisbec@gmail.com>,
        jason.low2@hp.com
Date: Mon, 29 Jun 2015 15:11:24 -0700
In-Reply-To: <CAKdL+dSM=_NERJ6U3rky-t=yiTkh3o_GFC-Bwy0dPVmTFBU+iQ@mail.gmail.com>
References: <1434099316-29749-1-git-send-email-fredrik.markstrom@gmail.com>
	 <1434099316-29749-2-git-send-email-fredrik.markstrom@gmail.com>
	 <1434104217.1495.74.camel@twins>
	 <20150612110158.GA18673@twins.programming.kicks-ass.net>
	 <CAKdL+dQWGtzURUe+4cB4XtsoaEPh0p0O1ejzbgxN0AUsbvUi0g@mail.gmail.com>
	 <20150629145837.GE3644@twins.programming.kicks-ass.net>
	 <CAKdL+dRPEenCzi14SWypOv6Vv+x2X0bHQXXc-G6gqUT+VhOtUw@mail.gmail.com>
	 <1435604090.21928.19.camel@j-VirtualBox>
	 <CAKdL+dSM=_NERJ6U3rky-t=yiTkh3o_GFC-Bwy0dPVmTFBU+iQ@mail.gmail.com>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 8bit
Mime-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1459
Lines: 39

On Mon, 2015-06-29 at 21:08 +0200, Fredrik Markström wrote:
> I don't think that is good enough. I believe the reason the
> max()-stuff was initially put there to make sure the returned stime
> and utime components are increasing monotonically. The scaling code
> can cause either or to decrease from one call to the other even i
> rtime increases.
> 
> The purpose of my patch is to also make sure that the sum of utime and
> stime is rtime.
> 
> I lost the last part of the patch in my previous email:
> 
> 
> -       cputime_advance(&prev->stime, stime);
> -       cputime_advance(&prev->utime, utime);
> +       if (stime < prev->stime) {
> +               stime = prev->stime;
> +               utime = rtime - stime;
> +       } else if (utime < prev->utime) {
> +               utime = prev->utime;
> +               stime = rtime - utime;
> +       }
> -out:
> +       if (prev->stime + prev->utime < rtime) {
> +               prev->stime = stime;
> +               prev->utime = utime;
> +       }
>         *ut = prev->utime;
>         *st = prev->stime;

In this case, we might want to avoid the extra stime and utime
computations if prev->stime + prev->utime >= rtime, since they wouldn't
get used.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/