Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753320AbbF2XDZ (ORCPT ); Mon, 29 Jun 2015 19:03:25 -0400 Received: from smtp.codeaurora.org ([198.145.29.96]:59935 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750981AbbF2XDS (ORCPT ); Mon, 29 Jun 2015 19:03:18 -0400 Message-ID: <5591CEB2.1080001@codeaurora.org> Date: Mon, 29 Jun 2015 16:03:14 -0700 From: Stephen Boyd User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: tglx@linutronix.de, john.stultz@linaro.org, linux-kernel@vger.kernel.org, ahh@google.com, joe@perches.com, pjt@google.com, yamada.m@jp.panasonic.com, mmarek@suse.cz, sam@ravnborg.org, mingo@kernel.org, hpa@zytor.com, hofrat@osadl.org, linux-tip-commits@vger.kernel.org Subject: Re: [tip:timers/core] time: Move timeconst.h into include/generated References: <1431951554-5563-1-git-send-email-hofrat@osadl.org> In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 3534 Lines: 106 On 05/19/2015 06:36 AM, tip-bot for Nicholas Mc Guire wrote: > Commit-ID: 0a227985d4a993a322ff72ecbaeee2611d624216 > Gitweb: http://git.kernel.org/tip/0a227985d4a993a322ff72ecbaeee2611d624216 > Author: Nicholas Mc Guire > AuthorDate: Mon, 18 May 2015 14:19:12 +0200 > Committer: Thomas Gleixner > CommitDate: Tue, 19 May 2015 15:13:45 +0200 > > time: Move timeconst.h into include/generated > > kernel/time/timeconst.h is moved to include/generated/ and generated > by the top level Kbuild. This allows using timeconst.h in an earlier > build stage. > > Signed-off-by: Nicholas Mc Guire > Cc: Masahiro Yamada > Cc: Sam Ravnborg > Cc: Joe Perches > Cc: John Stultz > Cc: Andrew Hunter > Cc: Paul Turner > Cc: Michal Marek > Link: http://lkml.kernel.org/r/1431951554-5563-1-git-send-email-hofrat@osadl.org > Signed-off-by: Thomas Gleixner > --- This patch seems to cause kernel/time/time.c to always need to be recompiled and the vmlinux to be relinked even if nothing has changed. make V=2 shows CC kernel/time/time.o - due to: include/config/ > diff --git a/Kbuild b/Kbuild > index 6f0d82a..df99a5f 100644 > --- a/Kbuild > +++ b/Kbuild > @@ -2,8 +2,9 @@ > # Kbuild for top-level directory of the kernel > # This file takes care of the following: > # 1) Generate bounds.h > -# 2) Generate asm-offsets.h (may need bounds.h) > -# 3) Check for missing system calls > +# 2) Generate timeconst.h > +# 3) Generate asm-offsets.h (may need bounds.h and timeconst.h) > +# 4) Check for missing system calls > > # Default sed regexp - multiline due to syntax constraints > define sed-y > @@ -47,7 +48,26 @@ $(obj)/$(bounds-file): kernel/bounds.s FORCE > $(call filechk,offsets,__LINUX_BOUNDS_H__) > > ##### > -# 2) Generate asm-offsets.h > +# 2) Generate timeconst.h > + > +timeconst-file := include/generated/timeconst.h > + > +#always += $(timeconst-file) Is there a reason this is commented out instead of removed? > +targets += $(timeconst-file) > + > +quiet_cmd_gentimeconst = GEN $@ > +define cmd_gentimeconst > [...] > diff --git a/kernel/time/Makefile b/kernel/time/Makefile > index 01f0312..ffc4cc3 100644 > --- a/kernel/time/Makefile > +++ b/kernel/time/Makefile > @@ -13,19 +13,4 @@ obj-$(CONFIG_TIMER_STATS) += timer_stats.o > obj-$(CONFIG_DEBUG_FS) += timekeeping_debug.o > obj-$(CONFIG_TEST_UDELAY) += test_udelay.o > > -$(obj)/time.o: $(obj)/timeconst.h > - > -quiet_cmd_hzfile = HZFILE $@ > - cmd_hzfile = echo "hz=$(CONFIG_HZ)" > $@ > - > -targets += hz.bc > -$(obj)/hz.bc: $(objtree)/include/config/hz.h FORCE > - $(call if_changed,hzfile) > - > -quiet_cmd_bc = BC $@ > - cmd_bc = bc -q $(filter-out FORCE,$^) > $@ > - > -targets += timeconst.h > -$(obj)/timeconst.h: $(obj)/hz.bc $(src)/timeconst.bc FORCE > - $(call if_changed,bc) > - > +$(obj)/time.o: $(objtree)/include/config/ It looks like it has to recompile because of this dependency. Can't we just remove this line? -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, a Linux Foundation Collaborative Project -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/