Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1753191AbbF2XLh (ORCPT <rfc822;w@1wt.eu>);
	Mon, 29 Jun 2015 19:11:37 -0400
Received: from mga11.intel.com ([192.55.52.93]:35415 "EHLO mga11.intel.com"
	rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP
	id S1751080AbbF2XLb convert rfc822-to-8bit (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 29 Jun 2015 19:11:31 -0400
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.15,373,1432623600"; 
   d="scan'208";a="752829923"
From: "Luck, Tony" <tony.luck@intel.com>
To: Xishi Qiu <qiuxishi@huawei.com>, Andrew Morton <akpm@linux-foundation.org>,
        "H. Peter Anvin" <hpa@zytor.com>, Ingo Molnar <mingo@kernel.org>,
        Hanjun Guo <guohanjun@huawei.com>, Xiexiuqi <xiexiuqi@huawei.com>,
        "leon@leon.nu" <leon@leon.nu>,
        Kamezawa Hiroyuki <kamezawa.hiroyu@jp.fujitsu.com>,
        "Hansen, Dave" <dave.hansen@intel.com>,
        Naoya Horiguchi <n-horiguchi@ah.jp.nec.com>,
        Vlastimil Babka <vbabka@suse.cz>, Mel Gorman <mgorman@suse.de>
CC: Linux MM <linux-mm@kvack.org>, LKML <linux-kernel@vger.kernel.org>
Subject: RE: [RFC v2 PATCH 7/8] mm: add the buddy system interface
Thread-Topic: [RFC v2 PATCH 7/8] mm: add the buddy system interface
Thread-Index: AQHQsIDtglWikYYiAUujGjxd5awj4J3EH3qg
Date: Mon, 29 Jun 2015 23:11:30 +0000
Message-ID: <3908561D78D1C84285E8C5FCA982C28F32AA124A@ORSMSX114.amr.corp.intel.com>
References: <558E084A.60900@huawei.com> <558E0A28.6060607@huawei.com>
In-Reply-To: <558E0A28.6060607@huawei.com>
Accept-Language: en-US
Content-Language: en-US
X-MS-Has-Attach: 
X-MS-TNEF-Correlator: 
x-originating-ip: [10.22.254.139]
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 8BIT
MIME-Version: 1.0
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Length: 2632
Lines: 52

> @@ -814,7 +814,7 @@ int __init_memblock memblock_clear_hotplug(phys_addr_t base, phys_addr_t size)
>   */
>  int __init_memblock memblock_mark_mirror(phys_addr_t base, phys_addr_t size)
>  {
> -	system_has_some_mirror = true;
> +	static_key_slow_inc(&system_has_mirror);
> 
>  	return memblock_setclr_flag(base, size, 1, MEMBLOCK_MIRROR);
>  }

This generates some WARN_ON noise when called from efi_find_mirror():

[    0.000000] e820: last_pfn = 0x7b800 max_arch_pfn = 0x400000000
[    0.000000] ------------[ cut here ]------------
[    0.000000] WARNING: CPU: 0 PID: 0 at kernel/jump_label.c:61 static_key_slow_inc+0x57/0xc0()
[    0.000000] static_key_slow_inc used before call to jump_label_init
[    0.000000] Modules linked in:

[    0.000000] CPU: 0 PID: 0 Comm: swapper Not tainted 4.1.0 #4
[    0.000000] Hardware name: Intel Corporation BRICKLAND/BRICKLAND, BIOS BRHSXSD1.86B.0065.R01.1505011640 05/01/2015
[    0.000000]  0000000000000000 ee366a8dff38f745 ffffffff81997d68 ffffffff816683b4
[    0.000000]  0000000000000000 ffffffff81997dc0 ffffffff81997da8 ffffffff8107b0aa
[    0.000000]  ffffffff81d48822 ffffffff81f281a0 0000000040000000 0000001fcb7a4000
[    0.000000] Call Trace:
[    0.000000]  [<ffffffff816683b4>] dump_stack+0x45/0x57
[    0.000000]  [<ffffffff8107b0aa>] warn_slowpath_common+0x8a/0xc0
[    0.000000]  [<ffffffff8107b135>] warn_slowpath_fmt+0x55/0x70
[    0.000000]  [<ffffffff81660273>] ? memblock_add_range+0x175/0x19e
[    0.000000]  [<ffffffff81176c57>] static_key_slow_inc+0x57/0xc0
[    0.000000]  [<ffffffff81660655>] memblock_mark_mirror+0x19/0x33
[    0.000000]  [<ffffffff81b12c18>] efi_find_mirror+0x59/0xdd
[    0.000000]  [<ffffffff81afb8a6>] setup_arch+0x642/0xccf
[    0.000000]  [<ffffffff81af3120>] ? early_idt_handler_array+0x120/0x120
[    0.000000]  [<ffffffff81663480>] ? printk+0x55/0x6b
[    0.000000]  [<ffffffff81af3120>] ? early_idt_handler_array+0x120/0x120
[    0.000000]  [<ffffffff81af3d93>] start_kernel+0xe8/0x4eb
[    0.000000]  [<ffffffff81af3120>] ? early_idt_handler_array+0x120/0x120
[    0.000000]  [<ffffffff81af3120>] ? early_idt_handler_array+0x120/0x120
[    0.000000]  [<ffffffff81af35ee>] x86_64_start_reservations+0x2a/0x2c
[    0.000000]  [<ffffffff81af373c>] x86_64_start_kernel+0x14c/0x16f
[    0.000000] ---[ end trace baa7fa0514e3bc58 ]---
[    0.000000] ------------[ cut here ]------------





--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/