Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753276AbbF2XiU (ORCPT ); Mon, 29 Jun 2015 19:38:20 -0400 Received: from mail-yk0-f178.google.com ([209.85.160.178]:36267 "EHLO mail-yk0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752522AbbF2XiN (ORCPT ); Mon, 29 Jun 2015 19:38:13 -0400 MIME-Version: 1.0 In-Reply-To: <55904A9E.5060002@hurleysoftware.com> References: <1435439824-3975-1-git-send-email-batrick@batbytes.com> <1435452689-25390-1-git-send-email-batrick@batbytes.com> <55904A9E.5060002@hurleysoftware.com> Date: Mon, 29 Jun 2015 19:38:12 -0400 Message-ID: Subject: Re: [PATCH v2 1/2] tty: add missing rcu_read_lock for task_pgrp From: Patrick Donnelly To: Peter Hurley Cc: Greg Kroah-Hartman , Jiri Slaby , open list Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 762 Lines: 22 Hi Peter, On Sun, Jun 28, 2015 at 3:27 PM, Peter Hurley wrote: > The label name changing is not really necessary and would reduce diff count. I've removed the label changes in the next series. Thanks for the feedback. > It would be nice to get the printk() out from the locks as well (in a follow-on > patch?) I don't follow what you're referring to. Is it these lines? if (!tty->pgrp) { printk(KERN_WARNING "tty_check_change: tty->pgrp == NULL!\n"); -- Patrick Donnelly -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/