Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753200AbbF3A3e (ORCPT ); Mon, 29 Jun 2015 20:29:34 -0400 Received: from mail-vn0-f48.google.com ([209.85.216.48]:44129 "EHLO mail-vn0-f48.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751398AbbF3A31 (ORCPT ); Mon, 29 Jun 2015 20:29:27 -0400 MIME-Version: 1.0 In-Reply-To: <1435591877-18214-4-git-send-email-vaibhav.hiremath@linaro.org> References: <1435591877-18214-1-git-send-email-vaibhav.hiremath@linaro.org> <1435591877-18214-4-git-send-email-vaibhav.hiremath@linaro.org> Date: Tue, 30 Jun 2015 09:29:26 +0900 X-Google-Sender-Auth: OhtYwRG_5WAB_YL8Kj7YFrI_Szg Message-ID: Subject: Re: [PATCH-V5 3/4] mfd: 88pm800: Set default interrupt clear method From: Krzysztof Kozlowski To: Vaibhav Hiremath Cc: linux-arm-kernel@lists.infradead.org, Zhao Ye , devicetree@vger.kernel.org, sameo@linux.intel.com, yizhang@marvell.com, linux-kernel@vger.kernel.org, robh+dt@kernel.org, lee.jones@linaro.org Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1082 Lines: 33 2015-06-30 0:31 GMT+09:00 Vaibhav Hiremath : > As per the spec, bit 1 (INT_CLEAR_MODE) of reg addr 0xe > (page 0) controls the method of clearing interrupt > status of 88pm800 family of devices; > > 0: clear on read > 1: clear on write > > If pdata is not coming from board file, then set the > default irq clear method to "irq clear on write" > > Also, as suggested by "Lee Jones" renaming variable field > to appropriate name. > > Signed-off-by: Zhao Ye > Signed-off-by: Vaibhav Hiremath > --- > drivers/mfd/88pm800.c | 15 ++++++++++----- > include/linux/mfd/88pm80x.h | 10 ++++++++-- > 2 files changed, 18 insertions(+), 7 deletions(-) > Looks fine to me. Reviewed-by: Krzysztof Kozlowski Best regards, Krzysztof -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/