Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753421AbbF3CBg (ORCPT ); Mon, 29 Jun 2015 22:01:36 -0400 Received: from mgwkm03.jp.fujitsu.com ([202.219.69.170]:53863 "EHLO mgwkm03.jp.fujitsu.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751754AbbF3CB2 (ORCPT ); Mon, 29 Jun 2015 22:01:28 -0400 X-SecurityPolicyCheck: OK by SHieldMailChecker v2.3.2 X-SHieldMailCheckerPolicyVersion: FJ-ISEC-20150223 X-SHieldMailCheckerMailID: c0ab22e01ca94bde8fc9845d3e2b3111 Message-ID: <5591F862.7030706@jp.fujitsu.com> Date: Tue, 30 Jun 2015 11:01:06 +0900 From: Kamezawa Hiroyuki User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Xishi Qiu CC: "Luck, Tony" , Andrew Morton , "H. Peter Anvin" , Ingo Molnar , Hanjun Guo , Xiexiuqi , "leon@leon.nu" , "Hansen, Dave" , Naoya Horiguchi , Vlastimil Babka , Mel Gorman , Linux MM , LKML Subject: Re: [RFC v2 PATCH 7/8] mm: add the buddy system interface References: <558E084A.60900@huawei.com> <558E0A28.6060607@huawei.com> <3908561D78D1C84285E8C5FCA982C28F32AA124A@ORSMSX114.amr.corp.intel.com> <5591EA50.1000000@jp.fujitsu.com> <5591F18E.3060504@huawei.com> In-Reply-To: <5591F18E.3060504@huawei.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-TM-AS-MML: disable Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1377 Lines: 43 On 2015/06/30 10:31, Xishi Qiu wrote: > On 2015/6/30 9:01, Kamezawa Hiroyuki wrote: > >> On 2015/06/30 8:11, Luck, Tony wrote: >>>> @@ -814,7 +814,7 @@ int __init_memblock memblock_clear_hotplug(phys_addr_t base, phys_addr_t size) >>>> */ >>>> int __init_memblock memblock_mark_mirror(phys_addr_t base, phys_addr_t size) >>>> { >>>> - system_has_some_mirror = true; >>>> + static_key_slow_inc(&system_has_mirror); >>>> >>>> return memblock_setclr_flag(base, size, 1, MEMBLOCK_MIRROR); >>>> } >>> >>> This generates some WARN_ON noise when called from efi_find_mirror(): >>> >> >> It seems jump_label_init() is called after memory initialization. (init/main.c::start_kernel()) >> So, it may be difficut to use static_key function for our purpose because >> kernel memory allocation may occur before jump_label is ready. >> >> Thanks, >> -Kame >> > > Hi Kame, > > How about like this? Use static bool in bootmem, and use jump label in buddy system. > This means we use two variable to do it. > I think it can be done but it should be done in separated patch with enough comment/changelog. Thanks, -Kame -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/