Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752628AbbF3Gci (ORCPT ); Tue, 30 Jun 2015 02:32:38 -0400 Received: from mail-ob0-f182.google.com ([209.85.214.182]:33193 "EHLO mail-ob0-f182.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751737AbbF3Gca (ORCPT ); Tue, 30 Jun 2015 02:32:30 -0400 MIME-Version: 1.0 In-Reply-To: References: <20150614220057.GC29802@yumi.tdiedrich.de> Date: Tue, 30 Jun 2015 08:32:30 +0200 Message-ID: Subject: Re: [PATCH v2] gpio / ACPI: Add label to the gpio request From: Linus Walleij To: Alexandre Courbot Cc: Tobias Diedrich , Mika Westerberg , "Rafael J. Wysocki" , Andy Shevchenko , "linux-gpio@vger.kernel.org" , Linux Kernel Mailing List Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1810 Lines: 47 On Mon, Jun 15, 2015 at 4:29 AM, Alexandre Courbot wrote: > On Mon, Jun 15, 2015 at 7:00 AM, Tobias Diedrich > wrote: >> In leds-gpio.c create_gpio_led only the legacy path propagates the label >> by passing it into devm_gpio_request_one. Similarily gpio_keys_polled.c >> also neglects to propagate the name to the gpio subsystem. >> >> On the newer devicetree/acpi path the label is lost as far as the GPIO >> subsystem goes (it is only retained as name in struct gpio_led. >> >> Amend devm_get_gpiod_from_child to take an additonal (optional) label >> argument and propagate it so it will show up in /sys/kernel/debug/gpio. >> >> So instead of: >> >> GPIOs 288-511, platform/PRP0001:00, AMD SBX00: >> gpio-475 (? ) in hi >> gpio-477 (? ) out hi >> gpio-478 (? ) out lo >> gpio-479 (? ) out hi >> >> we get the much nicer output: >> >> GPIOs 288-511, platform/PRP0001:00, AMD SBX00: >> gpio-475 (switch1 ) in hi >> gpio-477 (led1 ) out hi >> gpio-478 (led2 ) out lo >> gpio-479 (led3 ) out hi > > We want to reuse higher-level information (like the con_id) as much as > possible to generate labels, but in the case of > devm_get_gpiod_from_child() there is no such information available > anyway, so why not. > > Acked-by: Alexandre Courbot I don't have the actual v2 patch in my inbox :( Tobias, can you resend a v3 with the ACKs. Yours, Linus Walleij -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/