Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752226AbbF3HS0 (ORCPT ); Tue, 30 Jun 2015 03:18:26 -0400 Received: from spo001.leaseweb.nl ([83.149.101.17]:40337 "EHLO spo001.leaseweb.nl" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750698AbbF3HSU (ORCPT ); Tue, 30 Jun 2015 03:18:20 -0400 X-Greylist: delayed 1206 seconds by postgrey-1.27 at vger.kernel.org; Tue, 30 Jun 2015 03:18:19 EDT Date: Tue, 30 Jun 2015 08:58:07 +0200 From: Wim Van Sebroeck To: Paul Gortmaker Cc: Guenter Roeck , poeschel@lemonage.de, Jonathan Corbet , LKML doc , linux-watchdog@vger.kernel.org, LKML , "linux-next@vger.kernel.org" Subject: Re: [PATCH v2] watchdog: omap_wdt: early_enable module parameter Message-ID: <20150630065807.GA5645@spo001.leaseweb.nl> References: <1435227711-29875-1-git-send-email-poeschel@lemonage.de> <558C0634.9050802@roeck-us.net> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.4.1i Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1422 Lines: 41 Hi Paul, > On Thu, Jun 25, 2015 at 9:46 AM, Guenter Roeck wrote: > > On 06/25/2015 03:21 AM, poeschel@lemonage.de wrote: > >> > >> From: Lars Poeschel > >> > >> Add a early_enable module parameter to the omap_wdt that starts the > >> watchdog on module insertion. The default value is 0 which does not > >> start the watchdog - which also does not change the behavior if the > >> parameter is not given. > >> > >> Signed-off-by: Lars Poeschel > > > > > > Reviewed-by: Guenter Roeck > > In case the info hasn't looped back around yet, this breaks the > omap builds in linux-next: > > drivers/watchdog/omap_wdt.c:288:18: error: 'omap_wdt' undeclared > (first use in this function) > > (Not sure how this could have ever worked as-is.) > > http://kisskb.ellerman.id.au/kisskb/buildresult/12452335/ > > I see a patch has already been posted to arm-kernel but not > Cc'd to all originally involved so figured I'd mention it. It's fixed. The reason why we din't catch it was because of interference with 'watchdog: omap: put struct watchdog_device into driver data'. Kind regards, Wim. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/