Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751643AbbF3H3v (ORCPT ); Tue, 30 Jun 2015 03:29:51 -0400 Received: from smtprelay2.synopsys.com ([198.182.60.111]:37738 "EHLO smtprelay.synopsys.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1750992AbbF3H3n (ORCPT ); Tue, 30 Jun 2015 03:29:43 -0400 Message-ID: <55924508.9080101@synopsys.com> Date: Tue, 30 Jun 2015 12:58:08 +0530 From: Vineet Gupta User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 Newsgroups: gmane.linux.kernel.cross-arch,gmane.linux.kernel.mm,gmane.linux.kernel To: Laurent Dufour , Geert Uytterhoeven , Andrew Morton CC: , , Subject: Re: [PATCH] mm: cleaning per architecture MM hook header files References: <1435587909-23163-1-git-send-email-ldufour@linux.vnet.ibm.com> In-Reply-To: <1435587909-23163-1-git-send-email-ldufour@linux.vnet.ibm.com> Content-Type: text/plain; charset="windows-1252" Content-Transfer-Encoding: 7bit X-Originating-IP: [10.12.197.226] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2534 Lines: 72 On Monday 29 June 2015 07:55 PM, Laurent Dufour wrote: > The commit 2ae416b142b6 ("mm: new mm hook framework") introduced an empty > header file (mm-arch-hooks.h) for every architecture, even those which > doesn't need to define mm hooks. > > As suggested by Geert Uytterhoeven, this could be cleaned through the use > of a generic header file included via each per architecture > asm/include/Kbuild file. > > The powerpc architecture is not impacted here since this architecture has > to defined the arch_remap MM hook. > > Signed-off-by: Laurent Dufour > Suggested-by: Geert Uytterhoeven > CC: Andrew Morton > CC: linux-arch@vger.kernel.org > CC: linux-mm@kvack.org > CC: linux-kernel@vger.kernel.org > --- snipped.... > diff --git a/arch/arc/include/asm/Kbuild b/arch/arc/include/asm/Kbuild > index 769b312c1abb..2febe6ff32ed 100644 > --- a/arch/arc/include/asm/Kbuild > +++ b/arch/arc/include/asm/Kbuild > @@ -49,3 +49,4 @@ generic-y += ucontext.h > generic-y += user.h > generic-y += vga.h > generic-y += xor.h > +generic-y += mm-arch-hooks.h > diff --git a/arch/arc/include/asm/mm-arch-hooks.h b/arch/arc/include/asm/mm-arch-hooks.h > deleted file mode 100644 > index c37541c5f8ba..000000000000 > --- a/arch/arc/include/asm/mm-arch-hooks.h > +++ /dev/null > @@ -1,15 +0,0 @@ > -/* > - * Architecture specific mm hooks > - * > - * Copyright (C) 2015, IBM Corporation > - * Author: Laurent Dufour > - * > - * This program is free software; you can redistribute it and/or modify > - * it under the terms of the GNU General Public License version 2 as > - * published by the Free Software Foundation. > - */ > - > -#ifndef _ASM_ARC_MM_ARCH_HOOKS_H > -#define _ASM_ARC_MM_ARCH_HOOKS_H > - > -#endif /* _ASM_ARC_MM_ARCH_HOOKS_H */ > diff --git a/arch/arm/include/asm/Kbuild b/arch/arm/include/asm/Kbuild > index 83c50193626c..870a2f7cbada 100644 > --- a/arch/arm/include/asm/Kbuild > +++ b/arch/arm/include/asm/Kbuild > @@ -36,3 +36,4 @@ generic-y += termios.h > generic-y += timex.h > generic-y += trace_clock.h > generic-y += unaligned.h > +generic-y += mm-arch-hooks.h We keep this file sorted by headers so please can u respin with right ordering ! Thx, -Vineet -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/