Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752689AbbF3H6b (ORCPT ); Tue, 30 Jun 2015 03:58:31 -0400 Received: from mail-pa0-f46.google.com ([209.85.220.46]:36658 "EHLO mail-pa0-f46.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752926AbbF3H6Y (ORCPT ); Tue, 30 Jun 2015 03:58:24 -0400 Message-ID: <55924C17.6090604@linaro.org> Date: Tue, 30 Jun 2015 13:28:15 +0530 From: Vaibhav Hiremath User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:31.0) Gecko/20100101 Thunderbird/31.7.0 MIME-Version: 1.0 To: Tony Lindgren CC: Linus Walleij , lee.jones@linaro.org, sameo@linux.intel.com, linux-gpio@vger.kernel.org, "linux-arm-kernel@lists.infradead.org" , linux-kernel@vger.kernel.org Subject: Re: Use of pinctrl-single for external device over I2C References: <55893B2C.1070800@linaro.org> <558A9CC7.6070409@linaro.org> <20150624133349.GI4156@atomide.com> <558AE478.2080802@linaro.org> <20150625043838.GK4156@atomide.com> <558B95CA.9070105@linaro.org> <55924953.80802@linaro.org> In-Reply-To: <55924953.80802@linaro.org> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2110 Lines: 72 On Tuesday 30 June 2015 01:16 PM, Vaibhav Hiremath wrote: > > > On Thursday 25 June 2015 11:16 AM, Vaibhav Hiremath wrote: >> >> >> On Thursday 25 June 2015 10:08 AM, Tony Lindgren wrote: >>> * Vaibhav Hiremath [150624 10:12]: >>>> >>>> I do not like this, as this is not HW feature, so DT may not be right >>>> approach. >>>> >>>> So I will dig more from either runtime or Compile time option to use >>>> regmap_ Vs raw read/writes. >>> >>> Can't you just check if the pinctrl node has compatible = "syscon" >>> property? >>> >>> A compile time option won't work for sure. I don't know what you >>> would check at runtime as you do not know what the bus is behind >>> syscon. >>> >> >> Although, I haven't gone through syscon, but not sure whether syscon >> would be useful. >> >> As you rightly stated, we need to know the bus behind regmap. >> > > Trying to understand what is the right way of doing pinctrl of external > device on board, > > I feel it would not be good idea to pollute pinctrl-single driver, and > also I am still not able to figure out how can I have access to bus > behind regmap. > > > How about having separate driver (generic for all I2C), say pinctrl- > i2c.c, which is i2c_client driver and would support pinctrl and pinmux > on I2C client device. > I mean, part of mfd here (mfd_cell) > > The current usecase which I have is pretty simple in nature, > > 88PM860 has few GPIO pins which can be configured to different > functionality, based on board design. > In most of the cases they are one/init/boot time settings. > > GPIO_0: > ======= > 000 = GPIO input mode > 001 = GPIO output mode > 010 = SLEEPOUTN mirror mode > 011 = Buck4 FPWM enable > 100 = 32 Khz output buffer mode > 101 = PMICINTN output mode > 110 = HW_RESET1 mode > 111 = HW_RESET2 mode > > > Thanks, > Vaibhav -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/