MIME-version: 1.0
Content-type: text/plain; charset=UTF-8; format=flowed
Content-transfer-encoding: 8BIT
Message-id: <559252EC.2050906@samsung.com>
Date: Tue, 30 Jun 2015 10:27:24 +0200
From: Jacek Anaszewski <j.anaszewski@samsung.com>
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:17.0) Gecko/20130804
 Thunderbird/17.0.8
To: Stas Sergeev <stsp@users.sourceforge.net>
Cc: Jacek Anaszewski <j.anaszewski@samsung.com>, linux-leds@vger.kernel.org,
        linux-kernel@vger.kernel.org, Bryan Wu <cooloney@gmail.com>,
        Richard Purdie <rpurdie@rpsys.net>, Pavel Machek <pavel@ucw.cz>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Andreas Werner <andreas.werner@men.de>, Andrew Lunn <andrew@lunn.ch>,
        Antonio Ospite <ospite@studenti.unina.it>,
        Atsushi Nemoto <anemo@mba.ocn.ne.jp>, Ben Dooks <ben@simtec.co.uk>,
        Chris Boot <bootc@bootc.net>, Dan Murphy <dmurphy@ti.com>,
        Daniel Jeong <daniel.jeong@ti.com>, Daniel Mack <daniel@zonque.org>,
        "David S. Miller" <davem@davemloft.net>,
        Fabio Baltieri <fabio.baltieri@gmail.com>, Felipe Balbi <balbi@ti.com>,
        Florian Fainelli <florian@openwrt.org>,
        "G.Shark Jeong" <gshark.jeong@gmail.com>,
        Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
        Ingi Kim <ingi2.kim@samsung.com>, Jan-Simon Moeller <dl9pf@gmx.de>,
        Johan Hovold <johan@kernel.org>, John Lenz <lenz@cs.wisc.edu>,
        Jonas Gorski <jogo@openwrt.org>, Kim Kyuwon <q1.kim@samsung.com>,
        Kristian Kielhofner <kris@krisk.org>,
        Kristoffer Ericson <kristoffer.ericson@gmail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Mark Brown <broonie@kernel.org>,
        Michael Hennerich <michael.hennerich@analog.com>,
        Milo Kim <milo.kim@ti.com>,
        =?UTF-8?B?TcOhcnRvbiBOw6ltZXRo?= <nm127@freemail.hu>,
        Nate Case <ncase@xes-inc.com>, NeilBrown <neilb@suse.de>,
        Nick Forbes <nick.forbes@incepta.com>,
        Paul Parsons <lost.distance@yahoo.com>,
        Peter Meerwald <p.meerwald@bct-electronic.com>,
        Phil Sutter <n0-1@freewrt.org>,
        Philippe Retornaz <philippe.retornaz@epfl.ch>,
        Raphael Assenat <raph@8d.com>, Richard Purdie <rpurdie@openedhand.com>,
        Rod Whitby <rod@whitby.id.au>, Dave Hansen <dave@sr71.net>,
        Rodolfo Giometti <giometti@linux.it>,
        "Sebastian A. Siewior" <bigeasy@linutronix.de>,
        Shuah Khan <shuahkhan@gmail.com>, Simon Guinot <sguinot@lacie.com>,
        =?UTF-8?B?w4FsdmFybyBGZXJuw6FuZGV6IFJvamFz?= <noltari@gmail.com>
Subject: Re: [PATCH/RFC RESEND] leds: Use set_brightness_work for
 brightness_set ops that can sleep
References: <1435651268-9657-1-git-send-email-j.anaszewski@samsung.com>
In-reply-to: <1435651268-9657-1-git-send-email-j.anaszewski@samsung.com>
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1046
Lines: 27

On 06/29/2015 05:17 PM, Stas Sergeev wrote:> 29.06.2015 17:05, Jacek 
Anaszewski пишет:
 >> +		 * If need to disable soft blinking delegate this to the
 >> +		 * work queue task to avoid problems in case we are
 >> +		 * called from hard irq context.
 >> +		 */
 >> +		led_cdev->flags |= LED_BLINK_DISABLE;
 > Wouldn't it be better to just enforce the callers
 > to explicitly disable software blink, so that it to
 > never happen from irq context? Something like in this
 > patch:
 > https://lkml.org/lkml/2015/5/13/491
 >

Blinking can be disabled not only by removing trigger explicitly,
but also by setting brightness to 0 and led_set_brightness
can be called from hard irq context. set_brightness_work
was originally introduced exactly for this use case.

-- 
Best Regards,
Jacek Anaszewski
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/