Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752518AbbF3KhG (ORCPT ); Tue, 30 Jun 2015 06:37:06 -0400 Received: from mail-pa0-f44.google.com ([209.85.220.44]:35365 "EHLO mail-pa0-f44.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751643AbbF3Kgz (ORCPT ); Tue, 30 Jun 2015 06:36:55 -0400 Subject: Re: vfio: powerpc/spapr: One function call less in tce_iommu_attach_group() after kzalloc() failure To: SF Markus Elfring , Alex Williamson , kvm@vger.kernel.org References: <5307CAA2.8060406@users.sourceforge.net> <530A086E.8010901@users.sourceforge.net> <530A72AA.3000601@users.sourceforge.net> <530B5FB6.6010207@users.sourceforge.net> <530C5E18.1020800@users.sourceforge.net> <530CD2C4.4050903@users.sourceforge.net> <530CF8FF.8080600@users.sourceforge.net> <530DD06F.4090703@users.sourceforge.net> <5317A59D.4@users.sourceforge.net> <55901E68.80205@users.sourceforge.net> <55901FAC.1090109@users.sourceforge.net> <5590862A.3010603@ozlabs.ru> <5590DF8A.8030503@users.sourceforge.net> <5591E355.1080708@ozlabs.ru> <55923251.7070306@users.sourceforge.net> Cc: LKML , kernel-janitors@vger.kernel.org, Julia Lawall , Michael Ellerman From: Alexey Kardashevskiy Message-ID: <5592713D.10701@ozlabs.ru> Date: Tue, 30 Jun 2015 20:36:45 +1000 User-Agent: Mozilla/5.0 (X11; Linux i686 on x86_64; rv:38.0) Gecko/20100101 Thunderbird/38.0.1 MIME-Version: 1.0 In-Reply-To: <55923251.7070306@users.sourceforge.net> Content-Type: text/plain; charset=koi8-r; format=flowed Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 688 Lines: 23 On 06/30/2015 04:08 PM, SF Markus Elfring wrote: >>>> than the existing one should have been renamed to "free_exit" or "free_unlock_exit" >>>> and new one would be "unlock_exit". >>> >>> I chose a smaller change at this place. >> >> I'd just drop this patch. > > How do you think about to improve the affected jump labels > a bit more there? This branch is very unlikely to work ever so I cannot think of any improvement here. -- Alexey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/