Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752937AbbF3Kv7 (ORCPT ); Tue, 30 Jun 2015 06:51:59 -0400 Received: from opensource.wolfsonmicro.com ([80.75.67.52]:39748 "EHLO opensource.wolfsonmicro.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752379AbbF3Kvv (ORCPT ); Tue, 30 Jun 2015 06:51:51 -0400 Date: Tue, 30 Jun 2015 11:51:49 +0100 From: Charles Keepax To: cw00.choi@samsung.com Cc: Lee Jones , "myungjoo.ham@samsung.com" , Samuel Ortiz , devicetree , linux-kernel , patches@opensource.wolfsonmicro.com Subject: Re: [PATCH v5 1/7] extcon: arizona: Simplify pdata symantics for micd_dbtime Message-ID: <20150630105149.GK6321@opensource.wolfsonmicro.com> References: <1434731014-19980-1-git-send-email-ckeepax@opensource.wolfsonmicro.com> <1434731014-19980-2-git-send-email-ckeepax@opensource.wolfsonmicro.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.17+20080114 (2008-01-14) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1637 Lines: 45 On Sun, Jun 21, 2015 at 11:17:56PM +0900, Chanwoo Choi wrote: > Hi Charles, > > Looks good go me. But you need the review from MFD maintainer > before appling it. > > Thanks, > Chanwoo Choi > > On Sat, Jun 20, 2015 at 1:23 AM, Charles Keepax > wrote: > > Currently micd_dbtime can be set to 0 for default, 1 for 4 measurements, > > or a greater than 16-bit value for 2 measurements. This patch simplifies > > the symantics to 2 for 2 measurements, 4 for 4 measurements and any > > other value for the default. > > > > I am not super keen on changing the symantics of the pdata at this stage > > in the drivers life, but acceptance of the DT binding for this field has > > been made conditional on this happening. > > > > Signed-off-by: Charles Keepax > > --- > > diff --git a/include/linux/mfd/arizona/pdata.h b/include/linux/mfd/arizona/pdata.h > > index aa5c48b..bd68355 100644 > > --- a/include/linux/mfd/arizona/pdata.h > > +++ b/include/linux/mfd/arizona/pdata.h > > @@ -53,6 +53,9 @@ > > > > #define ARIZONA_MAX_PDM_SPK 2 > > > > +#define ARIZONA_MICD_DBTIME_TWO_READINGS 2 > > +#define ARIZONA_MICD_DBTIME_FOUR_READINGS 4 > > + I am gonna respin and move these into the extcon driver itself, should allow us to get the patch merged and their use in the pdata header is probably minimal. Thanks, Charles -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/