Date: Tue, 30 Jun 2015 13:58:09 +0200
From: Pavel Machek <pavel@denx.de>
To: Jacek Anaszewski <j.anaszewski@samsung.com>
Cc: linux-leds@vger.kernel.org, linux-kernel@vger.kernel.org,
        Bryan Wu <cooloney@gmail.com>, Richard Purdie <rpurdie@rpsys.net>,
        Stas Sergeev <stsp@users.sourceforge.net>,
        Sakari Ailus <sakari.ailus@linux.intel.com>,
        Andreas Werner <andreas.werner@men.de>, Andrew Lunn <andrew@lunn.ch>,
        Antonio Ospite <ospite@studenti.unina.it>,
        Atsushi Nemoto <anemo@mba.ocn.ne.jp>, Ben Dooks <ben@simtec.co.uk>,
        Chris Boot <bootc@bootc.net>, Dan Murphy <dmurphy@ti.com>,
        Daniel Jeong <daniel.jeong@ti.com>, Daniel Mack <daniel@zonque.org>,
        "David S. Miller" <davem@davemloft.net>,
        Fabio Baltieri <fabio.baltieri@gmail.com>, Felipe Balbi <balbi@ti.com>,
        Florian Fainelli <florian@openwrt.org>,
        "G.Shark Jeong" <gshark.jeong@gmail.com>,
        Guennadi Liakhovetski <g.liakhovetski@gmx.de>,
        Ingi Kim <ingi2.kim@samsung.com>, Jan-Simon Moeller <dl9pf@gmx.de>,
        Johan Hovold <johan@kernel.org>, John Lenz <lenz@cs.wisc.edu>,
        Jonas Gorski <jogo@openwrt.org>, Kim Kyuwon <q1.kim@samsung.com>,
        Kristian Kielhofner <kris@krisk.org>,
        Kristoffer Ericson <kristoffer.ericson@gmail.com>,
        Linus Walleij <linus.walleij@linaro.org>,
        Mark Brown <broonie@kernel.org>,
        Michael Hennerich <michael.hennerich@analog.com>,
        Milo Kim <milo.kim@ti.com>,
        =?iso-8859-1?Q?M=E1rton_N=E9meth?= <nm127@freemail.hu>,
        Nate Case <ncase@xes-inc.com>, NeilBrown <neilb@suse.de>,
        Nick Forbes <nick.forbes@incepta.com>,
        Paul Parsons <lost.distance@yahoo.com>,
        Peter Meerwald <p.meerwald@bct-electronic.com>,
        Phil Sutter <n0-1@freewrt.org>,
        Philippe Retornaz <philippe.retornaz@epfl.ch>,
        Raphael Assenat <raph@8d.com>, Richard Purdie <rpurdie@openedhand.com>,
        Rod Whitby <rod@whitby.id.au>, Dave Hansen <dave@sr71.net>,
        Rodolfo Giometti <giometti@linux.it>,
        "Sebastian A. Siewior" <bigeasy@linutronix.de>,
        Shuah Khan <shuahkhan@gmail.com>, Simon Guinot <sguinot@lacie.com>,
        =?iso-8859-1?Q?=C1lvaro_Fern=E1ndez?= Rojas <noltari@gmail.com>
Subject: Re: [PATCH/RFC RESEND] leds: Use set_brightness_work for
 brightness_set ops that can sleep
Message-ID: <20150630115809.GA13605@amd>
References: <1435651268-9657-1-git-send-email-j.anaszewski@samsung.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1435651268-9657-1-git-send-email-j.anaszewski@samsung.com>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1178
Lines: 25

On Tue 2015-06-30 10:01:08, Jacek Anaszewski wrote:
> This patch rearranges the core LED subsystem code, so that it
> now removes from drivers the responsibility of using work queues
> internally in case their brightness_set ops can sleep.
> Addition of two flags: LED_BRIGHTNESS_FAST and LED_BLINK_DISABLE
> as well as new_brightness_value property to the struct led_classdev
> allows for employing existing set_brightness_work to do the job.
> The modifications allow also to get rid of brightness_set_sync op,
> as flash LED devices can now be handled properly only basing on the
> SET_BRIGHTNESS_SYNC flag.

Are you sure this is good idea?

You'll now use single callback for blocking and non-blocking
behaviour. I'm pretty sure stuff like lockdep will have some fun with
that.
									Pavel
-- 
(english) http://www.livejournal.com/~pavelmachek
(cesky, pictures) http://atrey.karlin.mff.cuni.cz/~pavel/picture/horses/blog.html
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/