Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752940AbbF3Mok (ORCPT ); Tue, 30 Jun 2015 08:44:40 -0400 Received: from casper.infradead.org ([85.118.1.10]:53626 "EHLO casper.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751949AbbF3Moi (ORCPT ); Tue, 30 Jun 2015 08:44:38 -0400 Date: Tue, 30 Jun 2015 14:44:26 +0200 From: Peter Zijlstra To: Prarit Bhargava Cc: "H. Peter Anvin" , Andy Lutomirski , Ingo Molnar , "linux-kernel@vger.kernel.org" , Thomas Gleixner , Ingo Molnar , X86 ML , Len Brown , Dasaratharaman Chandramouli , Borislav Petkov , Andy Lutomirski , Denys Vlasenko , Brian Gerst , Arnaldo Carvalho de Melo , Henrique de Moraes Holschuh , Matt Fleming Subject: Re: [PATCH] x86, msr: Allow read access to /dev/cpu/X/msr Message-ID: <20150630124426.GD12596@twins.programming.kicks-ass.net> References: <1435341131-3279-1-git-send-email-prarit@redhat.com> <20150627083354.GA12834@gmail.com> <20150627083921.GA13074@gmail.com> <559005DD.3070003@redhat.com> <5591A1D3.6010003@zytor.com> <559289A7.3040500@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <559289A7.3040500@redhat.com> User-Agent: Mutt/1.5.21 (2012-12-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1225 Lines: 28 On Tue, Jun 30, 2015 at 08:20:55AM -0400, Prarit Bhargava wrote: > it seems like visiting changes on each of these packages (and the other > packages that I'm sure I've missed) will be moderately difficult. > > Thoughts? Start by changing the ones users want to run most and leave the rest requiring root privs until someone has the time to convert them. Its not like we can remove the msr driver any time soon anyway. So I would suggest starting with the perf MSR driver thingy for all those MSRs that count things and see if you can convert say turbostat/cpufrequtils/powertop over to that. I suspect there's MSR that are useful to expose but are not counting, I'm not sure perf is the right interface for those. Making an inventory on which MSRs are required by these tools and what kind of data they provide might give a good idea on how to continue. If most of these tools only use counting MSRs that can be serviced with the perf-msr driver then that would be great. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/