Date: Tue, 30 Jun 2015 14:57:36 +0200
From: Ingo Molnar <mingo@kernel.org>
To: Peter Zijlstra <peterz@infradead.org>
Cc: Prarit Bhargava <prarit@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
        Andy Lutomirski <luto@amacapital.net>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Thomas Gleixner <tglx@linutronix.de>, Ingo Molnar <mingo@redhat.com>,
        X86 ML <x86@kernel.org>, Len Brown <len.brown@intel.com>,
        Dasaratharaman Chandramouli 
	<dasaratharaman.chandramouli@intel.com>,
        Borislav Petkov <bp@alien8.de>, Andy Lutomirski <luto@kernel.org>,
        Denys Vlasenko <dvlasenk@redhat.com>, Brian Gerst <brgerst@gmail.com>,
        Arnaldo Carvalho de Melo <acme@infradead.org>,
        Henrique de Moraes Holschuh <hmh@hmh.eng.br>,
        Matt Fleming <matt@codeblueprint.co.uk>
Subject: Re: [PATCH] x86, msr: Allow read access to /dev/cpu/X/msr
Message-ID: <20150630125736.GB18196@gmail.com>
References: <1435341131-3279-1-git-send-email-prarit@redhat.com>
 <20150627083354.GA12834@gmail.com>
 <20150627083921.GA13074@gmail.com>
 <CALCETrXpiMWwiAfbxcKTDYCewrwq-UTwLV+xXTxdOkd+B3G-OQ@mail.gmail.com>
 <559005DD.3070003@redhat.com>
 <5591A1D3.6010003@zytor.com>
 <559289A7.3040500@redhat.com>
 <20150630124426.GD12596@twins.programming.kicks-ass.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <20150630124426.GD12596@twins.programming.kicks-ass.net>
User-Agent: Mutt/1.5.23 (2014-03-12)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1687
Lines: 46


* Peter Zijlstra <peterz@infradead.org> wrote:

> On Tue, Jun 30, 2015 at 08:20:55AM -0400, Prarit Bhargava wrote:
> > it seems like visiting changes on each of these packages (and the other
> > packages that I'm sure I've missed) will be moderately difficult.
> > 
> > Thoughts?
> 
> Start by changing the ones users want to run most and leave the rest
> requiring root privs until someone has the time to convert them.

Yes, start by just converting the ones used by a single tool, say turbostat, and 
then convert turbostat (while keeping /dev/msr fall-back code as well) just to see 
what the tooling fallout is.

> Its not like we can remove the msr driver any time soon anyway.

Yes.

> So I would suggest starting with the perf MSR driver thingy for all
> those MSRs that count things and see if you can convert say
> turbostat/cpufrequtils/powertop over to that.

One of those tools would be enough, to keep the complexity of the initial 
submission low - and to allow a change of plans if necessary.

> I suspect there's MSR that are useful to expose but are not counting, I'm not 
> sure perf is the right interface for those.
>
> Making an inventory on which MSRs are required by these tools and what kind of 
> data they provide might give a good idea on how to continue.
> 
> If most of these tools only use counting MSRs that can be serviced with the 
> perf-msr driver then that would be great.

Fully agreed!

Thanks,

	Ingo
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/