Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753125AbbF3Nlx (ORCPT ); Tue, 30 Jun 2015 09:41:53 -0400 Received: from mail-ob0-f178.google.com ([209.85.214.178]:33985 "EHLO mail-ob0-f178.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752858AbbF3Nll (ORCPT ); Tue, 30 Jun 2015 09:41:41 -0400 MIME-Version: 1.0 In-Reply-To: <1435253451-19817-2-git-send-email-grygorii.strashko@ti.com> References: <1435253451-19817-1-git-send-email-grygorii.strashko@ti.com> <1435253451-19817-2-git-send-email-grygorii.strashko@ti.com> From: Alexandre Courbot Date: Tue, 30 Jun 2015 22:41:21 +0900 Message-ID: Subject: Re: [PATCH 2/2] gpiolib: assign chip owner to dev->driver->owner if not set To: Grygorii Strashko Cc: Linus Walleij , Sekhar Nori , "linux-gpio@vger.kernel.org" , Linux Kernel Mailing List , Johan Hovold Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 936 Lines: 27 On Fri, Jun 26, 2015 at 2:30 AM, Grygorii Strashko wrote: > Assign GPIO chip owner field to chip->dev->driver->owner if it was not > configured by GPIO driver. Sounds good, setting this field manually seems to make less and less sense anyway as most drivers follow the device model. > > Cc: Johan Hovold > Signed-off-by: Grygorii Strashko > --- > Hi, > > There is also one positive additional side effect: > lines like below can be removed from a lot of GPIO > drivers > rdc321x_gpio_dev->chip.owner = THIS_MODULE; A good idea for a follow-up patch! ;) Acked-by: Alexandre Courbot -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/