Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753544AbbF3Nrv (ORCPT ); Tue, 30 Jun 2015 09:47:51 -0400 Received: from mail-ie0-f174.google.com ([209.85.223.174]:34883 "EHLO mail-ie0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751447AbbF3Nrp (ORCPT ); Tue, 30 Jun 2015 09:47:45 -0400 MIME-Version: 1.0 In-Reply-To: <558BF0E4.50602@gmail.com> References: <558BED42.1030000@gmail.com> <20150625120949.GZ3644@twins.programming.kicks-ass.net> <558BF0E4.50602@gmail.com> Date: Tue, 30 Jun 2015 09:47:44 -0400 X-Google-Sender-Auth: gWkj62JK2ZrkVygG4HiA4v3KxpA Message-ID: Subject: Re: Regression: sched/preempt: Add static_key() to preempt_notifiers breaks my KVM From: Josh Boyer To: Pontus Fuchs Cc: Peter Zijlstra , Ingo Molnar , "linux-kernel@vger.kernel.org" , Gleb Natapov Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1599 Lines: 52 On Thu, Jun 25, 2015 at 8:15 AM, Pontus Fuchs wrote: > On 2015-06-25 14:09, Peter Zijlstra wrote: >> >> On Thu, Jun 25, 2015 at 02:00:02PM +0200, Pontus Fuchs wrote: >>> >>> Hi, >>> >> >> That seems pointless.. >> >> --- >> virt/kvm/kvm_main.c | 5 +++-- >> 1 file changed, 3 insertions(+), 2 deletions(-) >> >> diff --git a/virt/kvm/kvm_main.c b/virt/kvm/kvm_main.c >> index 90977418aeb6..d7aafa0458a0 100644 >> --- a/virt/kvm/kvm_main.c >> +++ b/virt/kvm/kvm_main.c >> @@ -128,8 +128,9 @@ int vcpu_load(struct kvm_vcpu *vcpu) >> >> if (mutex_lock_killable(&vcpu->mutex)) >> return -EINTR; >> - cpu = get_cpu(); >> preempt_notifier_register(&vcpu->preempt_notifier); >> + >> + cpu = get_cpu(); >> kvm_arch_vcpu_load(vcpu, cpu); >> put_cpu(); >> return 0; >> @@ -139,8 +140,8 @@ void vcpu_put(struct kvm_vcpu *vcpu) >> { >> preempt_disable(); >> kvm_arch_vcpu_put(vcpu); >> - preempt_notifier_unregister(&vcpu->preempt_notifier); >> preempt_enable(); >> + preempt_notifier_unregister(&vcpu->preempt_notifier); >> mutex_unlock(&vcpu->mutex); >> } > > > Tested ok. Thanks. We've had a report of this in Fedora now. Is the above patch queued anywhere? https://bugzilla.redhat.com/show_bug.cgi?id=1237143 josh -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/