Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753694AbbF3NzB (ORCPT ); Tue, 30 Jun 2015 09:55:01 -0400 Received: from mx1.redhat.com ([209.132.183.28]:37547 "EHLO mx1.redhat.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752120AbbF3Nyy (ORCPT ); Tue, 30 Jun 2015 09:54:54 -0400 Date: Tue, 30 Jun 2015 15:54:49 +0200 From: Jiri Olsa To: "Liang, Kan" Cc: "acme@kernel.org" , "jolsa@kernel.org" , "ak@linux.intel.com" , "namhyung@kernel.org" , "eranian@google.com" , "Hunter, Adrian" , "dsahern@gmail.com" , "a.p.zijlstra@chello.nl" , "mingo@redhat.com" , "linux-kernel@vger.kernel.org" Subject: Re: [PATCH 2/2] perf,tools: check and re-organize evsel cpu maps Message-ID: <20150630135449.GB2789@krava.brq.redhat.com> References: <1435607735-6332-1-git-send-email-kan.liang@intel.com> <1435607735-6332-2-git-send-email-kan.liang@intel.com> <20150630121428.GF25631@krava.brq.redhat.com> <37D7C6CF3E00A74B8858931C1DB2F07701883578@SHSMSX103.ccr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <37D7C6CF3E00A74B8858931C1DB2F07701883578@SHSMSX103.ccr.corp.intel.com> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1556 Lines: 43 On Tue, Jun 30, 2015 at 01:42:49PM +0000, Liang, Kan wrote: > > > > > diff --git a/tools/perf/util/evlist.c b/tools/perf/util/evlist.c index > > > 6cfdee6..f179379 100644 > > > --- a/tools/perf/util/evlist.c > > > +++ b/tools/perf/util/evlist.c > > > @@ -1101,6 +1101,71 @@ int perf_evlist__mmap(struct perf_evlist > > *evlist, unsigned int pages, > > > return perf_evlist__mmap_ex(evlist, pages, overwrite, 0, false); } > > > > > > +static int cmp_ids(const void *a, const void *b) { > > > + return *(int *)a - *(int *)b; > > > +} > > > + > > > +static int perf_evlist__check_evsel_cpus(struct perf_evlist *evlist, > > > +struct perf_evsel *evsel) { > > > + const struct cpu_map *cpus = evlist->cpus; > > > + const int ncpus = cpu_map__nr(evlist->cpus); > > > + int j = 0, cpu_nr = 0, tmp = 0; > > > + int i; > > > + > > > + /* ensure we process id in increasing order */ > > > + qsort(evlist->cpus->map, evlist->cpus->nr, sizeof(int), cmp_ids); > > > > wouldn't sorting maps affect some other code? > > > > I didn't find any bad effect after sorting the maps. > Any codes I need to check? I dont think so, but I'm not sure either.. thats why I asked ;-) I guess any code dealing with cpu maps.. it might affect perf stat output.. but it looks sorted now anyway ;-) I dont think it's an issue jirka -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/