Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753279AbbF3Qc6 (ORCPT ); Tue, 30 Jun 2015 12:32:58 -0400 Received: from mail.skyhub.de ([78.46.96.112]:46359 "EHLO mail.skyhub.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752625AbbF3Qc4 (ORCPT ); Tue, 30 Jun 2015 12:32:56 -0400 Date: Tue, 30 Jun 2015 18:32:33 +0200 From: Borislav Petkov To: Andy Lutomirski Cc: x86@kernel.org, linux-kernel@vger.kernel.org, =?utf-8?B?RnLDqWTDqXJpYw==?= Weisbecker , Rik van Riel , Oleg Nesterov , Denys Vlasenko , Kees Cook , Brian Gerst , paulmck@linux.vnet.ibm.com Subject: Re: [PATCH v4 06/17] x86: Move C entry and exit code to arch/x86/entry/common.c Message-ID: <20150630163233.GE23297@pd.tnic> References: <8e6fd030cfaf1313f288cc4967077abfbf483480.1435602481.git.luto@kernel.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <8e6fd030cfaf1313f288cc4967077abfbf483480.1435602481.git.luto@kernel.org> User-Agent: Mutt/1.5.23 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1915 Lines: 58 On Mon, Jun 29, 2015 at 12:33:38PM -0700, Andy Lutomirski wrote: > The entry and exit C helpers were confusingly scattered between > ptrace.c and signal.c, even though they aren't specific to ptrace or > signal handling. Move them together in a new file. > > This change just moves code around. It doesn't change anything. > > Signed-off-by: Andy Lutomirski > --- > arch/x86/entry/Makefile | 1 + > arch/x86/entry/common.c | 253 ++++++++++++++++++++++++++++++++++++++++++ > arch/x86/include/asm/signal.h | 1 + > arch/x86/kernel/ptrace.c | 202 +-------------------------------- > arch/x86/kernel/signal.c | 28 +---- > 5 files changed, 257 insertions(+), 228 deletions(-) > create mode 100644 arch/x86/entry/common.c > > diff --git a/arch/x86/entry/Makefile b/arch/x86/entry/Makefile > index 7a144971db79..bd55dedd7614 100644 > --- a/arch/x86/entry/Makefile > +++ b/arch/x86/entry/Makefile > @@ -2,6 +2,7 @@ > # Makefile for the x86 low level entry code > # > obj-y := entry_$(BITS).o thunk_$(BITS).o syscall_$(BITS).o > +obj-y += common.o > > obj-y += vdso/ > obj-y += vsyscall/ > diff --git a/arch/x86/entry/common.c b/arch/x86/entry/common.c > new file mode 100644 > index 000000000000..348465473e55 > --- /dev/null > +++ b/arch/x86/entry/common.c > @@ -0,0 +1,253 @@ > +/* > + * entry.c - C code for kernel entry and exit common.c > + * Copyright (c) 2015 Andrew Lutomirski > + * GPL v2 > + * > + * Based on asm and ptrace code by many authors. The code here originated > + * in ptrace.c and signal.c. > + */ -- Regards/Gruss, Boris. ECO tip #101: Trim your mails when you reply. -- -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/