Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753499AbbF3Q6E (ORCPT ); Tue, 30 Jun 2015 12:58:04 -0400 Received: from e39.co.us.ibm.com ([32.97.110.160]:43749 "EHLO e39.co.us.ibm.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751311AbbF3Q54 (ORCPT ); Tue, 30 Jun 2015 12:57:56 -0400 X-Helo: d03dlp03.boulder.ibm.com X-MailFrom: paulmck@linux.vnet.ibm.com X-RcptTo: linux-kernel@vger.kernel.org Date: Tue, 30 Jun 2015 09:57:51 -0700 From: "Paul E. McKenney" To: Geert Uytterhoeven Cc: "linux-kernel@vger.kernel.org" , Ingo Molnar , laijs@cn.fujitsu.com, dipankar@in.ibm.com, Andrew Morton , Mathieu Desnoyers , Josh Triplett , Thomas Gleixner , Peter Zijlstra , Steven Rostedt , David Howells , Eric Dumazet , Darren Hart , =?iso-8859-1?Q?Fr=E9d=E9ric?= Weisbecker , Oleg Nesterov , pranith kumar Subject: Re: [PATCH tip/core/rcu 24/24] rcu: Conditionally compile RCU's eqs warnings Message-ID: <20150630165751.GF3717@linux.vnet.ibm.com> Reply-To: paulmck@linux.vnet.ibm.com References: <20150512223034.GA1396@linux.vnet.ibm.com> <1431469854-3826-1-git-send-email-paulmck@linux.vnet.ibm.com> <1431469854-3826-24-git-send-email-paulmck@linux.vnet.ibm.com> <20150629205528.GQ3717@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.5.21 (2010-09-15) X-TM-AS-MML: disable X-Content-Scanned: Fidelis XPS MAILER x-cbid: 15063016-0033-0000-0000-000005036D11 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2280 Lines: 62 On Mon, Jun 29, 2015 at 10:58:51PM +0200, Geert Uytterhoeven wrote: > Hi Paul, > > On Mon, Jun 29, 2015 at 10:55 PM, Paul E. McKenney > wrote: > > On Mon, Jun 29, 2015 at 11:39:13AM +0200, Geert Uytterhoeven wrote: > >> On Wed, May 13, 2015 at 12:30 AM, Paul E. McKenney > >> wrote: > >> > --- a/lib/Kconfig.debug > >> > +++ b/lib/Kconfig.debug > >> > @@ -1373,6 +1373,17 @@ config RCU_TRACE > >> > Say Y here if you want to enable RCU tracing > >> > Say N if you are unsure. > >> > > >> > +config RCU_EQS_DEBUG > >> > + bool "Use this when adding any sort of NO_HZ support to your arch" > >> > >> This sounds a bit fuzzy. Can you please provide a better one-line description? > >> Thanks! > > > > So the point of this Kconfig option is to provide WARN_ON()s that catch > > bug such as telling RCU that a given CPU entered idle, but failing to > > tell RCU when that CPU later leaves idle. So how about this? > > > > + bool "Provide debugging asserts for adding NO_HZ support to an arch" > > Much better, thanks! Queued the following for v4.3, thank you! Thanx, Paul ------------------------------------------------------------------------ commit bb651123a8ed43543f3ec8ac84e6152a866e2639 Author: Paul E. McKenney Date: Tue Jun 30 09:56:31 2015 -0700 rcu: Clarify CONFIG_RCU_EQS_DEBUG help text Reported-by: Geert Uytterhoeven Signed-off-by: Paul E. McKenney diff --git a/lib/Kconfig.debug b/lib/Kconfig.debug index 6be521990d61..80efaade5e59 100644 --- a/lib/Kconfig.debug +++ b/lib/Kconfig.debug @@ -1360,7 +1360,7 @@ config RCU_TRACE Say N if you are unsure. config RCU_EQS_DEBUG - bool "Use this when adding any sort of NO_HZ support to your arch" + bool "Provide debugging asserts for adding NO_HZ support to an arch" depends on DEBUG_KERNEL help This option provides consistency checks in RCU's handling of -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/