Date: Tue, 30 Jun 2015 20:45:18 +0300
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Joe Perches <joe@perches.com>
Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org,
        linux-kernel@vger.kernel.org, noralf@tronnes.org,
        Fabio Falzoi <fabio.falzoi84@gmail.com>
Subject: Re: [PATCH 07/10] Staging: fbtft: Remove useless newline
Message-ID: <20150630174518.GR28762@mwanda>
References: <1435646597-7612-1-git-send-email-fabio.falzoi84@gmail.com>
 <1435646597-7612-8-git-send-email-fabio.falzoi84@gmail.com>
 <20150630074225.GJ28762@mwanda>
 <1435676142.12101.7.camel@perches.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1435676142.12101.7.camel@perches.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1016
Lines: 28

On Tue, Jun 30, 2015 at 07:55:42AM -0700, Joe Perches wrote:
> On Tue, 2015-06-30 at 10:42 +0300, Dan Carpenter wrote:
> > On Tue, Jun 30, 2015 at 08:43:14AM +0200, Fabio Falzoi wrote:
> > > No newline is needed since checkpatch doesn't complain about line longer
> > > than 80 characters for string literals.
> []
> > The original was correct.
> 
> The original was fine.
> 
> > There was no need to go over 80 characters
> > just because of a limitation in checkpatch.
> 
> How is checkpatch not emitting a message on
> either form a limitation?

It's not an easily solvable limitation, but the original was better than
the new patch.  This patch is all like "I've found a way to do something
bad and checkpatch.pl doesn't catch it so woohoo!"

regards,
dan carpenter

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/