Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752798AbbF3UWp (ORCPT ); Tue, 30 Jun 2015 16:22:45 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:35143 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751591AbbF3UWf (ORCPT ); Tue, 30 Jun 2015 16:22:35 -0400 From: Grant Likely Subject: Re: [PATCH v1 05/10] device property: add fwnode_get_name() To: Tomeu Vizoso , linux-kernel@vger.kernel.org Cc: "Rafael J. Wysocki" , Mark Brown , Tomeu Vizoso , Greg Kroah-Hartman In-Reply-To: <1435676108-20590-6-git-send-email-tomeu.vizoso@collabora.com> References: <1435676108-20590-1-git-send-email-tomeu.vizoso@collabora.com> <1435676108-20590-6-git-send-email-tomeu.vizoso@collabora.com> Date: Tue, 30 Jun 2015 19:26:25 +0100 Message-Id: <20150630182625.CAAA4C40901@trevor.secretlab.ca> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2219 Lines: 66 On Tue, 30 Jun 2015 16:55:03 +0200 , Tomeu Vizoso wrote: > Getting a textual representation of a device node can be very useful for > debugging. > > Signed-off-by: Tomeu Vizoso > --- > > drivers/base/property.c | 15 +++++++++++++++ > include/linux/property.h | 2 ++ > 2 files changed, 17 insertions(+) > > diff --git a/drivers/base/property.c b/drivers/base/property.c > index a7fb46b..3280b04 100644 > --- a/drivers/base/property.c > +++ b/drivers/base/property.c > @@ -556,3 +556,18 @@ struct fwnode_handle *fwnode_get_parent(struct fwnode_handle *fwnode) > return NULL; > } > EXPORT_SYMBOL_GPL(fwnode_get_parent); > + > +/** > + * fwnode_get_name - return the name of a device node > + * @fwnode: Device node to find the name of > + */ > +const char *fwnode_get_name(struct fwnode_handle *fwnode) > +{ > + if (is_of_node(fwnode)) > + return to_of_node(fwnode)->full_name; of_node_full_name() please > + else if (is_acpi_node(fwnode)) > + return acpi_dev_name(to_acpi_node(fwnode)); > + > + return NULL; > +} > +EXPORT_SYMBOL_GPL(fwnode_get_name); > diff --git a/include/linux/property.h b/include/linux/property.h > index f47092d..020a53c 100644 > --- a/include/linux/property.h > +++ b/include/linux/property.h > @@ -65,6 +65,8 @@ struct fwnode_handle *device_get_next_child_node(struct device *dev, > > struct fwnode_handle *fwnode_get_parent(struct fwnode_handle *fwnode); > > +const char *fwnode_get_name(struct fwnode_handle *fwnode); > + > #define device_for_each_child_node(dev, child) \ > for (child = device_get_next_child_node(dev, NULL); child; \ > child = device_get_next_child_node(dev, child)) > -- > 2.4.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/