Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752612AbbF3UWz (ORCPT ); Tue, 30 Jun 2015 16:22:55 -0400 Received: from mail-wi0-f172.google.com ([209.85.212.172]:37765 "EHLO mail-wi0-f172.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752114AbbF3UWf (ORCPT ); Tue, 30 Jun 2015 16:22:35 -0400 From: Grant Likely Subject: Re: [PATCH v1 08/10] device property: add fwnode_is_compatible() To: Tomeu Vizoso , linux-kernel@vger.kernel.org Cc: "Rafael J. Wysocki" , Mark Brown , Tomeu Vizoso , Greg Kroah-Hartman In-Reply-To: <1435676108-20590-9-git-send-email-tomeu.vizoso@collabora.com> References: <1435676108-20590-1-git-send-email-tomeu.vizoso@collabora.com> <1435676108-20590-9-git-send-email-tomeu.vizoso@collabora.com> Date: Tue, 30 Jun 2015 19:28:44 +0100 Message-Id: <20150630182844.0A69AC40970@trevor.secretlab.ca> Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 2154 Lines: 63 On Tue, 30 Jun 2015 16:55:06 +0200 , Tomeu Vizoso wrote: > This is being added so code that is independent of the firmware being > used can match firmware nodes to devices. > > This commit only implements it for OF nodes. Hmmm, if it only works for OF nodes, then how is it firmware independent? What is the use case? > > Signed-off-by: Tomeu Vizoso > --- > > drivers/base/property.c | 9 +++++++++ > include/linux/property.h | 2 ++ > 2 files changed, 11 insertions(+) > > diff --git a/drivers/base/property.c b/drivers/base/property.c > index 92cdbb3..9c8be31 100644 > --- a/drivers/base/property.c > +++ b/drivers/base/property.c > @@ -585,3 +585,12 @@ const char *fwnode_get_name(struct fwnode_handle *fwnode) > return NULL; > } > EXPORT_SYMBOL_GPL(fwnode_get_name); > + > +bool fwnode_is_compatible(struct fwnode_handle *fwnode, const char *compatible) > +{ > + if (is_of_node(fwnode)) > + return of_device_is_compatible(to_of_node(fwnode), compatible); > + > + return false; > +} > +EXPORT_SYMBOL_GPL(fwnode_is_compatible); > diff --git a/include/linux/property.h b/include/linux/property.h > index cfd1eb2..bf10074 100644 > --- a/include/linux/property.h > +++ b/include/linux/property.h > @@ -80,6 +80,8 @@ const char *fwnode_get_name(struct fwnode_handle *fwnode); > > void fwnode_handle_put(struct fwnode_handle *fwnode); > > +bool fwnode_is_compatible(struct fwnode_handle *fwnode, const char *compatible); > + > unsigned int device_get_child_node_count(struct device *dev); > > static inline bool device_property_read_bool(struct device *dev, > -- > 2.4.1 > > -- > To unsubscribe from this list: send the line "unsubscribe linux-kernel" in > the body of a message to majordomo@vger.kernel.org > More majordomo info at http://vger.kernel.org/majordomo-info.html > Please read the FAQ at http://www.tux.org/lkml/ -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/