Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752379AbbF3TD4 (ORCPT ); Tue, 30 Jun 2015 15:03:56 -0400 Received: from smtprelay0124.hostedemail.com ([216.40.44.124]:46065 "EHLO smtprelay.hostedemail.com" rhost-flags-OK-OK-OK-FAIL) by vger.kernel.org with ESMTP id S1751124AbbF3TDu (ORCPT ); Tue, 30 Jun 2015 15:03:50 -0400 X-Session-Marker: 6A6F6540706572636865732E636F6D X-Spam-Summary: 2,0,0,,d41d8cd98f00b204,joe@perches.com,:::::::::::,RULES_HIT:41:355:379:541:599:973:988:989:1260:1277:1311:1313:1314:1345:1359:1373:1437:1515:1516:1518:1534:1541:1593:1594:1711:1730:1747:1777:1792:2198:2199:2393:2553:2559:2562:2828:3138:3139:3140:3141:3142:3352:3622:3865:3866:3867:3868:3870:3871:3872:4321:4434:5007:6261:9040:10004:10400:10848:11232:11658:11914:12517:12519:12740:13069:13095:13311:13357:21080,0,RBL:none,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fn,MSBL:0,DNSBL:none,Custom_rules:0:0:0 X-HE-Tag: low24_4085be2a7b4d X-Filterd-Recvd-Size: 2056 Message-ID: <1435691026.12101.21.camel@perches.com> Subject: Re: [PATCH 07/10] Staging: fbtft: Remove useless newline From: Joe Perches To: Dan Carpenter Cc: devel@driverdev.osuosl.org, gregkh@linuxfoundation.org, linux-kernel@vger.kernel.org, noralf@tronnes.org, Fabio Falzoi Date: Tue, 30 Jun 2015 12:03:46 -0700 In-Reply-To: <20150630174518.GR28762@mwanda> References: <1435646597-7612-1-git-send-email-fabio.falzoi84@gmail.com> <1435646597-7612-8-git-send-email-fabio.falzoi84@gmail.com> <20150630074225.GJ28762@mwanda> <1435676142.12101.7.camel@perches.com> <20150630174518.GR28762@mwanda> Content-Type: text/plain; charset="ISO-8859-1" X-Mailer: Evolution 3.12.11-0ubuntu3 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 1219 Lines: 33 On Tue, 2015-06-30 at 20:45 +0300, Dan Carpenter wrote: > On Tue, Jun 30, 2015 at 07:55:42AM -0700, Joe Perches wrote: > > On Tue, 2015-06-30 at 10:42 +0300, Dan Carpenter wrote: > > > On Tue, Jun 30, 2015 at 08:43:14AM +0200, Fabio Falzoi wrote: > > > > No newline is needed since checkpatch doesn't complain about line longer > > > > than 80 characters for string literals. > > [] > > > The original was correct. > > > > The original was fine. > > > > > There was no need to go over 80 characters > > > just because of a limitation in checkpatch. > > > > How is checkpatch not emitting a message on > > either form a limitation? > > It's not an easily solvable limitation, It's not a limitation at all. > but the original was better than > the new patch. This patch is all like "I've found a way to do something > bad and checkpatch.pl doesn't catch it so woohoo!" I think either form is fine, but because either is fine, it's not useful/better to change either. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/