Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752401AbbF3Uit (ORCPT ); Tue, 30 Jun 2015 16:38:49 -0400 Received: from mail-qg0-f54.google.com ([209.85.192.54]:34791 "EHLO mail-qg0-f54.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751042AbbF3Uij convert rfc822-to-8bit (ORCPT ); Tue, 30 Jun 2015 16:38:39 -0400 MIME-Version: 1.0 In-Reply-To: <9B4A1B1917080E46B64F07F2989DADD653571BF0@ORSMSX114.amr.corp.intel.com> References: <1435640130-1466-1-git-send-email-maninder1.s@samsung.com> <9B4A1B1917080E46B64F07F2989DADD653571921@ORSMSX114.amr.corp.intel.com> <9B4A1B1917080E46B64F07F2989DADD653571BF0@ORSMSX114.amr.corp.intel.com> From: Alex Gartrell Date: Tue, 30 Jun 2015 13:38:19 -0700 Message-ID: Subject: Re: [Intel-wired-lan] [PATCH 1/1] igb: Use ARRAY_SIZE instead fo sizeof(a)/sizeof(a[0]) To: "Fujinaka, Todd" Cc: Richard Weinberger , Maninder Singh , "Kirsher, Jeffrey T" , "Brandeburg, Jesse" , "Nelson, Shannon" , "Wyborny, Carolyn" , "Skidmore, Donald C" , "Vick, Matthew" , "Ronciak, John" , "Williams, Mitch A" , "intel-wired-lan@lists.osuosl.org" , "netdev@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "pankaj.m@samsung.com" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Length: 933 Lines: 18 On Tue, Jun 30, 2015 at 1:16 PM, Fujinaka, Todd wrote: > I still would say no if I'm allowed, because to guarantee that this change - that I don't think fixes anything - works in all cases, we need to do an incredible amount of regression testing. Every variant of every Intel part that uses this driver (and there are many) should be tested and will end up being used by the community. > Validation is really simple: diff old_module.ko new_module.ko And this is a good defensive measure, as it'll save you when someone screws up and changes your array to a pointer to an array (you'll get a build failure instead of 0). -- Alex Gartrell -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majordomo@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/