From: Arnd Bergmann <arnd@arndb.de>
To: Andrew Andrianov <andrew@ncrmnt.org>
Cc: Pawel Moll <pawel.moll@arm.com>, Mark Rutland <mark.rutland@arm.com>,
        "Rafael J. Wysocki" <rjw@rjwysocki.net>,
        Daniel Lezcano <daniel.lezcano@linaro.org>,
        Ian Campbell <ijc+devicetree@hellion.org.uk>,
        Kumar Gala <galak@codeaurora.org>,
        Russell King <linux@arm.linux.org.uk>,
        Rob Herring <robh+dt@kernel.org>, Pavel Shevchenko <pshevch@module.ru>,
        Andrew Andrianov <andrianov@module.ru>,
        linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 3/5] ARM: dts: rcm-k1879xb1: Add dts files for K1879XB1YA
Date: Tue, 30 Jun 2015 23:07:42 +0200
Message-ID: <2031644.ugW3XV6Cq8@wuerfel>
User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; )
In-Reply-To: <1435677307-6526-4-git-send-email-andrew@ncrmnt.org>
References: <1435677307-6526-1-git-send-email-andrew@ncrmnt.org> <1435677307-6526-4-git-send-email-andrew@ncrmnt.org>
MIME-Version: 1.0
Content-Transfer-Encoding: 7Bit
Content-Type: text/plain; charset="us-ascii"
Sender: linux-kernel-owner@vger.kernel.org
Content-Length: 1880
Lines: 74

On Tuesday 30 June 2015 18:15:05 Andrew Andrianov wrote:
> +	memory {
> +		device_type = "memory";
> +		reg = <0x40000000 0x8000000>;
> +	};
> +
> +	chosen {
> +		bootargs = "console=ttyS0,38400n8 earlyprintk=serial";
> +	};

Can you use earlycon instead?

> +
> +	clocks {
> +			clk_core: clk_core@324M {
> +				/* Core 324MHz clock. */
> +				compatible = "fixed-factor-clock";
> +				#clock-cells = <0>;
> +				clocks = <&oscillator_27m>;
> +				clock-div = <1>;
> +				clock-mult = <12>;
> +				clock-output-names = "clk_core";
> +			};

Indentation looks wrong.

> +	axi {
> +		compatible = "arm,amba-bus";
> +		#address-cells = <1>;
> +		#size-cells = <1>;
> +		ranges = <0 0x0 0xFFFFFFFF>;
> +
> +		usbehci: ehci@0x10040000 {
> +			compatible = "generic-ehci";
> +			reg = <0x10040000 0x2000>;
> +			interrupt-parent = <&vic1>;
> +			interrupts = <3>; /* 35 */
> +			status = "disabled";
> +		};
> +

Please use standard node names, e.g. "usb" instead of "ehci" and "ohci",
and "serial" instead of "uart".

> +
> +		dvb_ci0: dvb-ci@10050000 {
> +			compatible = "rcm,mdvbci";
> +			reg = <0x10050000 0x10000>;
> +			interrupts = <37>;
> +		};
> +
> +		xdmac0: xdmac@10070000 {
> +			compatible = "rcm,xdmac";
> +			reg = <0x10070000 0x10000>;
> +			interrupts = <16 17 18 19 20 21 22 23>;
> +		};

Remove the nodes that don't have an established binding for now.

> +		pinmux: sysconfigh@0x20033084 {
> +			compatible = "rcm,pinmux";
> +			reg = <0x20033084 0x4>;
> +			reg-names = "controlH";
> +		};

This looks like it's only one register out of a larger area of
random things. Can you use a "syscon" device instead"?

	Arnd
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/